DAOS-16898 cq: support user bash in githooks (#15648)

Replace hardcoded /bin/bash with /usr/bin/env bash in the githook
scripts, for the case where /bin/bash does not support newer features
like, e.g., mapfile.

replace mapfile with loop in get_release_branch

Signed-off-by: Dalton Bohning <[email protected]>

utils/cq/check_update_copyright.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 #  Copyright 2024 Intel Corporation.
 #  Copyright 2025 Hewlett Packard Enterprise Development LP

utils/githooks/find_base.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 # /*
 #  * (C) Copyright 2024 Intel Corporation.
+#  * (C) Copyright 2025 Hewlett Packard Enterprise Development LP
 #  *
 #  * SPDX-License-Identifier: BSD-2-Clause-Patent
 # */

utils/githooks/git-version.sh

@@ -1,4 +1,9 @@
-#!/bin/bash
+#!/usr/bin/env bash
+#
+#  Copyright 2025 Hewlett Packard Enterprise Development LP
+#
+#  SPDX-License-Identifier: BSD-2-Clause-Patent
+#
 
 VERSION=$(git --version | sed -ne 's/^[^0-9]*\([[0-9\.]*\).*/\1/p')
 if [ -z "$VERSION" ]; then

utils/githooks/hook_base.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 #  Copyright 2024 Intel Corporation.
+#  Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -41,8 +42,8 @@ run-parts() {
         # don't run vim .swp files
         [ "${i%.sw?}" != "${i}" ] && continue
         skip_item=false
-        for skip in "${skip_list[@]}"; do
-            if [[ "${i}" =~ ${skip} ]]; then
+        for skip in "${skip_list[@]:-}"; do
+            if [[ -n "${skip}" ]] && [[ "${i}" =~ ${skip} ]]; then
                 skip_item=true
                 echo "Skipping ${i}"
                 break

utils/githooks/pre-commit

@@ -1,4 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
+#
+# Copyright 2025 Hewlett Packard Enterprise Development LP
+#
 set -eu
 
 . utils/githooks/hook_base.sh

utils/githooks/pre-commit.d/10-update-copyright.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 #  Copyright 2022-2024 Intel Corporation.
+#  Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/20-codespell.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 #  Copyright 2024 Intel Corporation.
+#  Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/30-Jenkinsfile.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 #  Copyright 2023-2024 Intel Corporation.
+#  Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 #  SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/40-yamllint.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2022-2024 Intel Corporation.
+# Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/50-clang-format.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2022-2024 Intel Corporation.
+# Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/60-gofmt.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2022-2024 Intel Corporation.
+# Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/70-isort.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2023-2024 Intel Corporation.
+# Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/71-flake.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2022-2024 Intel Corporation.
+# Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/72-pylint.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2022-2024 Intel Corporation.
+# Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/pre-commit.d/73-ftest.sh

@@ -1,6 +1,7 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2024 Intel Corporation.
+# Copyright 2025 Hewlett Packard Enterprise Development LP
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #

utils/githooks/prepare-commit-msg

@@ -1,3 +1,6 @@
-#!/bin/bash
+#!/usr/bin/env bash
+#
+# Copyright 2025 Hewlett Packard Enterprise Development LP
+#
 
 . utils/githooks/hook_base.sh

utils/rpms/packaging/get_release_branch

@@ -1,14 +1,20 @@
-#!/bin/bash
-
+#!/usr/bin/env bash
+#
+# Copyright 2025 Hewlett Packard Enterprise Development LP
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
 # find the base branch of the current branch
 # base branches can be master, release/2.4+, release/3+
 # or optionally branches passed into $1
 set -eu -o pipefail
 IFS=' ' read -r -a add_bases <<< "${1:-}"
 origin="${ORIGIN:-origin}"
-mapfile -t all_bases < <(echo "master"
-                         git branch -r | sed -ne "/^  $origin\\/release\\/\(2.[4-9]\|[3-9]\)/s/^  $origin\\///p")
-all_bases+=("${add_bases[@]}")
+all_bases=()
+while IFS= read -r base; do
+    all_bases+=("$base")
+done < <(echo "master"
+         git branch -r | sed -ne "/^  $origin\\/release\\/\(2.[4-9]\|[3-9]\)/s/^  $origin\\///p")
 TARGET="master"
 min_diff=-1
 for base in "${all_bases[@]}"; do