Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-623 ci: Add config and Action for python formatting. #13281

Closed
wants to merge 33 commits into from
Closed

DAOS-623 ci: Add config and Action for python formatting. #13281

wants to merge 33 commits into from

Conversation

ashleypittman
Copy link
Contributor

Required-githooks: true

Signed-off-by: Ashley Pittman [email protected]

@ashleypittman
DAOS-623 ci: Add config and Action for python formatting.
3a4c9c6 
Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited
Loading

Bug-tracker data:
Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.4.2'
https://daosio.atlassian.net/browse/DAOS-623

daosbuild1
daosbuild1 reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Change options.
a63a134 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Change some things.
787a57a 
Required-githooks: true

Skip-func-hw-test: true
Skip-func-test: true
Quick-Functional: true
Test-tag: dfuse
@ashleypittman
Change more files.
2a4a5dc 
Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13281/2/display/redirect

daosbuild1
daosbuild1 reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Fix pylint.
1036d1e 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Rename a file.
d3fa8be 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Add a new package.
9996dc3 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Revert changes to utils, except using/sl
610ebaf 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Back out conflict.
2934722 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Merge branch 'master' into amd/black
0120f32
@ashleypittman
Fix isort errors.
98e1fff 
Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
back out cahge.
74056ef 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Required-githooks: true
a8161c7 
change scons file

Skip-func-hw-test: true
Skip-func-test: true
Quick-Functional: true
Test-tag: dfuse
@ashleypittman
Resolve conflicts.
b6613c1 
Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Merge branch 'master' into amd/black
9b1a448
@ashleypittman
make check it's own chek.
1160bfb 
Required-githooks: true

Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Revise code.
f8527f0 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Fix black check.
53c207c 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13281/13/testReport/

@ashleypittman
Merge branch 'master' into amd/black
90d3930 
Required-githooks: true
daosbuild1
daosbuild1 reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Fix file.
1f9bd95 
skip-build: true

Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

daosbuild1
daosbuild1 reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Add --diff option.
da1bb8d 
skip-build: true
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Fix conversion file.
a41d093 
skip-build: true
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
daosbuild1
daosbuild1 reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Back out conflict.
aa68870 
skip-build: true
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Merge branch 'master' into amd/black
2e56389
@ashleypittman
Fix the two files.
639ffe2 
Required-githooks: true
@ashleypittman
Back out raft cahnge
6d954ee 
Required-githooks: true
daosbuild1
daosbuild1 reviewed Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@ashleypittman
Merge branch \'amd/black\' into origin/master
0a6a0c3 
Required-githooks: true
@ashleypittman
Back out conflict.
a3d21e3 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Merge branch 'master' into amd/black
1b4898c 
Required-githooks: true
@ashleypittman
Patch build file.
631de86 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman
Update to 2024 stlye.
c02152f 
Required-githooks: true
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman ashleypittman deleted the amd/black branch February 9, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleypittman @daosbuild1