Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-14635 control: Remove agent default log path #13490

Merged
merged 7 commits into from
Jan 30, 2024
Merged

DAOS-14635 control: Remove agent default log path #13490

merged 7 commits into from
Jan 30, 2024

Conversation

kjacque
Copy link
Contributor

@kjacque kjacque commented Dec 13, 2023 •
edited
Loading

Without a logging path, the daos_agent will print logs to stdout instead of a default file location. This behavior is the same as the daos_server.

Features: control

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate watchers.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kjacque
DAOS-14635 control: Remove agent default log path
0651703 
Without a logging path, the daos_agent will print logs to
stdout instead of a default file location. This behavior is
the same as the daos_server.

Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque added the control-plane work on the management infrastructure of the DAOS Control Plane label Dec 13, 2023
@kjacque kjacque self-assigned this Dec 13, 2023
@kjacque kjacque requested a review from a team as a code owner December 13, 2023 00:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2023 •
edited
Loading

Bug-tracker data:
Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-14635

daosbuild1
daosbuild1 reviewed Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@kjacque
Copy link
Contributor Author

kjacque commented Dec 13, 2023

I verified this code manually by running the daos_server and daos_agent with and without log files defined in the config.

@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13490/1/testReport/

tanabarr
tanabarr previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@tanabarr tanabarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good refactor

src/control/common/cmdutil/logging.go Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13490/1/testReport/

@kjacque
Copy link
Contributor Author

kjacque commented Dec 13, 2023

Oops, I see a unit test failing because of one of my message changes. Will re-push.

@kjacque
Merge branch 'master' into kjacque/default-log-file
9b278b3
@kjacque
Fix unit test
1d44b95 
Also fixed whitespace issue.

Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <[email protected]>
daosbuild1
daosbuild1 reviewed Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-13490/2/execution/node/1163/log

@kjacque kjacque requested a review from tanabarr December 14, 2023 17:07
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13490/3/testReport/

@kjacque
Copy link
Contributor Author

kjacque commented Dec 19, 2023

Test failures are all from https://daosio.atlassian.net/browse/DAOS-14718

tanabarr
tanabarr previously approved these changes Dec 19, 2023
View reviewed changes
mjmac
mjmac reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mjmac mjmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, nice to consolidate this stuff. Just a few questions/comments.

src/control/common/cmdutil/logging.go Outdated Show resolved Hide resolved
src/control/cmd/daos_agent/main.go Outdated Show resolved Hide resolved
src/control/common/cmdutil/logging.go

// ConfigureLogger configures the logger according to the requested config.
func ConfigureLogger(logIn logging.Logger, cfg LogConfig) error {
log, ok := logIn.(*logging.LeveledLogger)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the typecast needed to get at the .WithJSONOutput() method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and the .SetLevel() method as well.

@kjacque
Merge branch 'master' into kjacque/default-log-file
a7bd6dc
@kjacque
Address review comments
aed3640 
Features: control

Required-githooks: true

Signed-off-by: Kris Jacque <[email protected]>
@kjacque kjacque requested review from tanabarr and mjmac December 19, 2023 23:38
tanabarr
tanabarr previously approved these changes Dec 20, 2023
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13490/4/testReport/

mjmac
mjmac previously approved these changes Dec 20, 2023
View reviewed changes
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-13490/5/testReport/

@kjacque
Copy link
Contributor Author

kjacque commented Dec 21, 2023

Failures are from https://daosio.atlassian.net/browse/DAOS-14718 again

@kjacque kjacque added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 21, 2023
@kjacque kjacque requested a review from a team December 21, 2023 21:23
knard38
knard38 previously approved these changes Jan 2, 2024
View reviewed changes
@knard38
Copy link
Contributor

knard38 commented Jan 2, 2024

CI failures seems to not be related to this PR as they are also happening in the PR https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-13546/1/testReport/ from @tanabarr .

@ashleypittman
Copy link
Contributor

Details

Also seems to be failing in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/weekly-testing/361/

@kjacque
Copy link
Contributor Author

kjacque commented Jan 2, 2024

@daos-stack/daos-gatekeeper Any reason not to force land this one? The failures are all existing failures.

@kjacque kjacque removed the request for review from a team January 22, 2024 17:11
@kjacque kjacque removed the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 22, 2024
@kjacque
Merge branch 'master' into kjacque/default-log-file
964f7bf 
Features: control

Required-githooks: true
@kjacque kjacque dismissed stale reviews from knard38, tanabarr, and mjmac via 964f7bf January 24, 2024 17:19
@kjacque kjacque requested review from mjmac, tanabarr and knard38 January 25, 2024 18:21
@kjacque kjacque requested a review from a team January 26, 2024 16:56
@mjmac mjmac merged commit ee729b4 into master Jan 30, 2024
51 checks passed
@mjmac mjmac deleted the kjacque/default-log-file branch January 30, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@knard38 knard38 knard38 approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac mjmac approved these changes

Assignees

@kjacque kjacque

Labels
control-plane work on the management infrastructure of the DAOS Control Plane
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kjacque @daosbuild1 @knard38 @ashleypittman @mjmac @tanabarr