-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-10250 control: Get enabled and disabled ranks with dmg pool query (#14436) #14548
Conversation
Bug-tracker data: |
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14548/1/execution/node/176/log |
@knard-intel: FYI, I'd like to backport this to our google/2.4 branch. I had to massage it a bit to do the "old-style" pool query that is used in 2.4.x. In my local testing, it worked fine. |
#14436) Allow enabled and disabled ranks option to be used simultaneously (DAOS-10250). Update and add cmocka unit tests of engine management related functions (DAOS-10253). Fix memory leaks of ranks string in function ds_mgmt_drpc_pool_query(). Required-githooks: true Change-Id: I27f5b3acb003faea2d53697e83f0afeb0e284080 Signed-off-by: Cedric Koch-Hofer <[email protected]>
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-14548/2/execution/node/148/log |
@jolivier23: Do we care about these checkpatch failures? Guessing maybe it's just due to a difference in linting rules between the branches. |
I generally ignore those, particularly on cherry-picks but I would expect those to happen on master branch too unless someone changed .clang-format there |
It seems to fail on lines not updated by this PR. |
Allow enabled and disabled ranks option to be used simultaneously (DAOS-10250).
Update and add cmocka unit tests of engine management related functions (DAOS-10253).
Fix memory leaks of ranks string in function ds_mgmt_drpc_pool_query().
Required-githooks: true
Change-Id: I27f5b3acb003faea2d53697e83f0afeb0e284080
Signed-off-by: Cedric Koch-Hofer [email protected]