Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #14943

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

WIP #14943

wants to merge 19 commits into from

Conversation

ryon-jensen
Copy link
Contributor

  • Working on new workflow
  • Moved all other workflows to disabled folder

Doc-only: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@ryon-jensen ryon-jensen force-pushed the ryon-jensen/gha_unittests branch 6 times, most recently from 835ef27 to f8fbad9 Compare August 15, 2024 19:06
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14943/10/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14943/21/display/redirect

- Working on new workflow
- Moved all other workflows to disabled folder

Doc-only: true

Signed-off-by: Ryon Jensen <[email protected]>
@ryon-jensen ryon-jensen force-pushed the ryon-jensen/gha_unittests branch from 8b32869 to 609b466 Compare October 23, 2024 17:13
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14943/60/display/redirect

Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-14943/64/display/redirect

Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Signed-off-by: Ryon Jensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants