Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16650 control: dmg system exclude, update group version (#15288) #15349

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Oct 20, 2024

With this change, when a daos administrator runs dmg system exclude for a given set of engines, the system map version / cart primary group version will be updated. In turn, daos_engines will more immediately detect the "loss" of the administratively excluded engines, update pool maps and perform rebuild. This change supports a use case of a proactive exclusion of ranks that are expected to be impacted by planned maintenance that would cut off connectivity to certain engines.

skip-nlt: true
Features: control ms_membership

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

Ticket title is 'DAOS 2.6.0 : 128 Node cluster, when user tried to start the few stopped engines, Different engine got crashed.'
Status is 'Awaiting backport'
Labels: 'ALCF'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16650

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 20, 2024
With this change, when a daos administrator runs dmg system exclude
for a given set of engines, the system map version / cart primary group
version will be updated. In turn, daos_engines will more immediately
detect the "loss" of the administratively excluded engines, update
pool maps and perform rebuild. This change supports a use case of
a proactive exclusion of ranks that are expected to be impacted by
planned maintenance that would cut off connectivity to certain
engines.

skip-nlt: true
Features: control ms_membership

Signed-off-by: Kenneth Cain <[email protected]>
@kccain kccain force-pushed the kccain/daos_16650_sysexclude_rel2p6 branch from 3e4b308 to 5b918d0 Compare October 21, 2024 02:24
@kccain
Copy link
Contributor Author

kccain commented Oct 21, 2024

In Jenkins build 1, the NLT "new warnings" failure is actually an instance of this known bug https://daosio.atlassian.net/browse/DAOS-16716

So I force-pushed a change to the PR to specify skip-nlt: true in the commit pragmas to get more testing done on this change.

@kccain kccain marked this pull request as ready for review October 22, 2024 02:51
@kccain kccain requested review from a team as code owners October 22, 2024 02:51
@kccain kccain added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 23, 2024
@kccain kccain requested a review from a team October 23, 2024 00:44
@kccain
Copy link
Contributor Author

kccain commented Oct 23, 2024

In Jenkins build 1, the NLT "new warnings" failure is actually an instance of this known bug https://daosio.atlassian.net/browse/DAOS-16716

So I force-pushed a change to the PR to specify skip-nlt: true in the commit pragmas to get more testing done on this change.

@daos-stack/daos-gatekeeper build 2 passed testing (minus NLT as noted due to DAOS-16716). Requesting a force landing. However, if you would prefer me merging latest release/2.6 branch (that very recently got a fix for that bug), I can do that and push for a final round of CI testing.

@daltonbohning daltonbohning merged commit 4c49f36 into release/2.6 Oct 23, 2024
54 checks passed
@daltonbohning daltonbohning deleted the kccain/daos_16650_sysexclude_rel2p6 branch October 23, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

3 participants