Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16685 dfuse: Change event queue poll to use NOWAIT. #15377

Merged
merged 10 commits into from
Oct 31, 2024
Merged

DAOS-16685 dfuse: Change event queue poll to use NOWAIT. #15377

merged 10 commits into from
Oct 31, 2024

Conversation

jgmoore-or
Copy link
Contributor

PR-repos: mercury@PR-125:4
Test-provider: ucx+dc_x
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: false

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jgmoore-or
DAOS-16685 dfuse: Change event queue poll to use NOWAIT.
89b5174 
PR-repos: mercury@PR-125:4
Test-provider: ucx+dc_x
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: false

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or jgmoore-or requested review from a team as code owners October 23, 2024 18:52
@jgmoore-or jgmoore-or marked this pull request as draft October 23, 2024 18:52
@github-actions GitHub Actions
Copy link

Ticket title is 'LRZ: Linux commands over dfuse hanging (crt_hg_req_send_cb, obj_shard_coll_query_cb timeouts)'
Status is 'In Progress'
Labels: 'lrz,pre_acceptance_issues,scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-16685

@jgmoore-or
DAOS-16685 dfuse: Change event queue poll to use NOWAIT.
bca93c9 
PR-repos: mercury@PR-125:4
Test-provider: ucx+dc_x
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: false
Features: dfuse

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
DAOS-16685 dfuse: Change event queue poll to use NOWAIT.
77da169 
PR-repos: mercury@PR-125:4
Test-provider: ucx+dc_x
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: false
Features: dfuse

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/4/execution/node/922/log

@jgmoore-or
DAOS-16685 dfuse: Change event queue poll to use NOWAIT.
a99f3a3 
PR-repos: mercury@PR-125:5
Test-provider: ucx+ud_x
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: false

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@Michael-Hennecke Michael-Hennecke self-requested a review October 24, 2024 15:10
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/6/execution/node/876/log

@jgmoore-or
DAOS-16685 dfuse: Set eq poll parameter to NOWAIT.
ff27c78 
Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
Merge branch 'master' into jgm/DAOS-16685
1ace06e
@jgmoore-or
DAOS-16685 dfuse: Set eq poll to NOWAIT.
33b1ebc 
PR-repos: mercury@PR-125:5
Test-provider: ucx+ud_x
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-func-hw-test-medium-verbs-provider: true
Skip-func-hw-test-medium-ucx-provider: false
Features: dfuse

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/8/execution/node/878/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/8/execution/node/1019/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/9/execution/node/829/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/9/execution/node/875/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/9/execution/node/921/log

@jgmoore-or
Merge branch 'master' into jgm/DAOS-16685
2249b24
@jgmoore-or
DAOS-16685 dfuse: Set NOWAIT for eq poll in progress thread.
de3f4a4 
Skip-func-hw-test-medium-ucx-provider: false
Features: dfuse

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or jgmoore-or marked this pull request as ready for review October 29, 2024 16:39
@jgmoore-or jgmoore-or requested a review from mchaarawi October 29, 2024 16:39
mchaarawi
mchaarawi reviewed Oct 29, 2024
View reviewed changes
src/client/dfuse/dfuse_core.c Outdated
@@ -32,7 +32,6 @@ dfuse_progress_thread(void *arg)
cont:
errno = 0;
rc = sem_wait(&eqt->de_sem);

Copy link
Contributor

@mchaarawi mchaarawi Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this change please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, leftover from some changes I made for debugging.

mchaarawi
mchaarawi previously approved these changes Oct 29, 2024
View reviewed changes
@jgmoore-or
DAOS-16685 dfuse: Change event queue poll to use NOWAIT.
08427f3 
Skip-func-hw-test-medium-ucx-provider: false
Features: dfuse

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15377/13/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15377/13/execution/node/1563/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15377/14/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15377/14/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15377/14/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15377/14/testReport/

frostedcmos
frostedcmos approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@frostedcmos frostedcmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we should keep ticket open (or add a new one) to investigate why version with DAOS_EQ_WAIT causes problems. I am concerned about things magically fixing themselves like this when WAIT variant should have worked fine to start with.

@mchaarawi
Copy link
Contributor

this is tested here:
#15391

@mchaarawi mchaarawi merged commit e2f1e22 into master Oct 31, 2024
49 of 55 checks passed
@mchaarawi mchaarawi deleted the jgm/DAOS-16685 branch October 31, 2024 15:57
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchaarawi mchaarawi mchaarawi approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@Michael-Hennecke Michael-Hennecke Awaiting requested review from Michael-Hennecke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgmoore-or @daosbuild1 @mchaarawi @frostedcmos