Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16845 test: add dynamic pool wait_for_aggregation #15553

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DAOS-16845 test: add dynamic pool wait_for_aggregation #15553

wants to merge 1 commit into from
+71 −24

Conversation

daltonbohning
Copy link
Contributor

Add TestPool.wait_for_aggregation to dynamically wait for pool aggregation to complete.
Update tests to use the new function.

Test-tag: test_enospace_time_with_fg
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning self-assigned this Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Ticket title is 'nvme/enospace.py:NvmeEnospace.test_enospace_time_with_fg - ior MPI_Abort No space left on device'
Status is 'In Progress'
Labels: 'ci_2.6_weekly,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16845

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15553/1/execution/node/936/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15553/2/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-16845 branch 2 times, most recently from 6cb9368 to 95c74d7 Compare December 4, 2024 16:23
daltonbohning
daltonbohning commented Dec 4, 2024
View reviewed changes
src/tests/ftest/util/test_utils_pool.py Outdated
@@ -1475,6 +1475,40 @@ def wait_pool_suspect_ranks(self, expected, interval=1, timeout=30):

self.log.info("Wait for suspect ranks complete: suspect ranks %s", expected)

def wait_for_aggregation(self, verify_scm=None, verify_nvme=None,
Copy link
Contributor Author

@daltonbohning daltonbohning Dec 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should rename to verify_free_space to be more clear on what it's doing

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15553/5/testReport/

@daltonbohning daltonbohning force-pushed the dbohning/daos-16845 branch 2 times, most recently from 74480a6 to 6d8f4b9 Compare January 8, 2025 22:17
@daltonbohning
DAOS-16845 test: add dynamic pool wait_for_aggregation
1969be3 
Add TestPool.wait_for_aggregation to dynamically wait for pool
aggregation to complete.
Update tests to use the new function.

Test-tag: test_enospace_time_with_fg DfuseSpaceCheck
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Dalton Bohning <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15553/8/execution/node/926/log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@daltonbohning daltonbohning

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daltonbohning @daosbuild1