Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-2171 ci: Big refactor of GHA workflows (#15556) #15588

Merged
merged 1 commit into from
Dec 13, 2024
Merged

SRE-2171 ci: Big refactor of GHA workflows (#15556) #15588

merged 1 commit into from
Dec 13, 2024

Conversation

brianjmurrell
Copy link
Contributor

@brianjmurrell brianjmurrell commented Dec 11, 2024 •
edited
Loading

Add the use of reusable workflows and actions to reduce the amount of
duplicated code in this repository as well as dependency repositories.

Run Bullseye workflow on schedule (#15574)
Saturdays at midnight, UTC.

Accept and propagate a run-gha variable (#15576)
For the case where daos is being used as a downstream test.

Fixes: SRE-2570 DAOS-16262

Run-GHA: true
Skip-PR-comments: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell brianjmurrell self-assigned this Dec 11, 2024
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/SRE-2171

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scorecard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@brianjmurrell brianjmurrell force-pushed the bmurrell/release-2.6-gha branch from ba883ab to 6e9bcc5 Compare December 11, 2024 14:14
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2024
View reviewed changes
.github/workflows/bullseye-coverage.yml
matrix: ${{ steps.matrix.outputs.text }}
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
COMMIT_STATUS_DISTRO_VERSION:
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
fetch-depth: 500
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
- name: Publish test results
if: (!cancelled()) && (success() || failure()) &&
steps.run-test.outcome != 'skipped'
uses: EnricoMi/publish-unit-test-result-action@v2

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 1: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/bullseye-coverage.yml
path: ${{ env.STAGE_NAME }}/**/results.xml
- name: Update commit status
if: contains(fromJSON('["push", "pull_request"]'), github.event_name)
uses: ouzi-dev/commit-status-updater@v2

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml Fixed Show fixed Hide fixed
.github/workflows/rpm-build-and-test.yml
DISTRO:
CLUSTER_REQUEST_reqid:
STAGE_NAME:
QUEUE_URL:
LABEL:
STAGE_TAGS:

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
DISTRO_NAME:
DISTRO_VERSION:
COMMIT_STATUS_DISTRO_VERSION:
steps:
- name: Checkout code

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
steps:
- name: Checkout code

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@brianjmurrell brianjmurrell force-pushed the bmurrell/release-2.6-gha branch from 552c37a to 36b6fa6 Compare December 11, 2024 14:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Functional on EL 8.8 Test Results

133 tests   129 ✅  1h 31m 53s ⏱️
 42 suites    4 💤
 42 files      0 ❌

Results for commit 36b6fa6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Functional on Leap 15.5 Test Results

133 tests   129 ✅  1h 24m 46s ⏱️
 42 suites    4 💤
 42 files      0 ❌

Results for commit 36b6fa6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Functional on EL 9.4 Test Results

133 tests   128 ✅  1h 36m 42s ⏱️
 42 suites    4 💤
 42 files      1 ❌

For more details on these failures, see this check.

Results for commit 36b6fa6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Functional Hardware Large Test Results

64 tests   64 ✅  26m 2s ⏱️
14 suites   0 💤
14 files     0 ❌

Results for commit 36b6fa6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Functional Hardware Medium Test Results

132 tests   105 ✅  2h 5m 16s ⏱️
 35 suites   27 💤
 35 files      0 ❌

Results for commit 36b6fa6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Functional Hardware Medium Verbs Provider Test Results

27 tests   26 ✅  7m 5s ⏱️
 6 suites   0 💤
 6 files     0 ❌  1 🔥

For more details on these errors, see this check.

Results for commit 36b6fa6.

@brianjmurrell
SRE-2171 ci: Big refactor of GHA workflows (#15556)
35af6f5 
Add the use of reusable workflows and actions to reduce the amount of
duplicated code in this repository as well as dependency repositories.

Run Bullseye workflow on schedule (#15574)
Saturdays at midnight, UTC.

Accept and propagate a run-gha variable (#15576)
For the case where daos is being used as a downstream test.

Test inputs context before trying to use it.

Fixes: SRE-2570 DAOS-16262

Skip-PR-comments: true
Test-tag: always_passes
Required-githooks: true

Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell brianjmurrell force-pushed the bmurrell/release-2.6-gha branch from 36b6fa6 to 35af6f5 Compare December 12, 2024 17:56
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 12, 2024
View reviewed changes
.github/workflows/rpm-build-and-test.yml
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
- name: Checkout code
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Import commit pragmas
uses: daos-stack/action-import-commit-pragmas@v1

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: third-party GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
.github/workflows/rpm-build-and-test.yml
steps:
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: GitHub-owned GitHubAction not pinned by hash
Remediation tip: update your workflow using https://app.stepsecurity.io
Click Remediation section below for further remediation help
@brianjmurrell brianjmurrell added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Dec 13, 2024
@brianjmurrell brianjmurrell marked this pull request as ready for review December 13, 2024 14:09
@brianjmurrell brianjmurrell requested a review from a team as a code owner December 13, 2024 14:09
@daltonbohning
Copy link
Contributor

FYI Ubuntu-related build failures will need #15563, #15255, #15607. I'm not sure whether this PR is safe to ignore those or not.

@brianjmurrell
Copy link
Contributor Author

FYI Ubuntu-related build failures will need #15563, #15255, #15607. I'm not sure whether this PR is safe to ignore those or not.

Yes, this PR should be unaffected by those -- other than their stages in CI fail, but that has no impact on the stages this PR adds. This PR does nothing with or about Ubuntu.

@brianjmurrell brianjmurrell requested a review from a team December 13, 2024 18:18
@brianjmurrell
Copy link
Contributor Author

Adding @daos-stack/daos-gatekeeper should this get approved for release/2.6. The main benefit of landing there is so that dependency build+test in GHA can validate against release/2.6 to ensure that landing a dependency update will not cause a regression on that branch -- exactly like we do in Jenkins.

@daltonbohning
Copy link
Contributor

Adding @daos-stack/daos-gatekeeper should this get approved for release/2.6. The main benefit of landing there is so that dependency build+test in GHA can validate against release/2.6 to ensure that landing a dependency update will not cause a regression on that branch -- exactly like we do in Jenkins.

Normally we should get merge approval before requesting gatekeeper. I requested approval on the ticket, which I expect to be approved

@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 13, 2024
@daltonbohning daltonbohning merged commit 2bed626 into release/2.6 Dec 13, 2024
66 of 73 checks passed
@daltonbohning daltonbohning deleted the bmurrell/release-2.6-gha branch December 13, 2024 21:48
@juszhan1 juszhan1 mentioned this pull request Dec 23, 2024
Closed
@mjmac mjmac mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryon-jensen ryon-jensen ryon-jensen approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@grom72 grom72 Awaiting requested review from grom72

@phender phender Awaiting requested review from phender

Assignees

@brianjmurrell brianjmurrell

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianjmurrell @daltonbohning @ryon-jensen