Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16865 cq: update flake8 to 7.1.1 (#15575) #15597

Merged
merged 1 commit into from
Dec 12, 2024
Merged

DAOS-16865 cq: update flake8 to 7.1.1 (#15575) #15597

merged 1 commit into from
Dec 12, 2024

Conversation

daltonbohning
Copy link
Contributor

Update flake8 to 7.1.1.
Adjust githook to work with newer flake8.
Also tested to be backwards compatible with flake8<6

Skip-build: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16865 cq: update flake8 to 7.1.1 (#15575)
7bf0a3c 
Update flake8 to 7.1.1.
Adjust githook to work with newer flake8.
Also tested to be backwards compatible with flake8<6

Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Dec 11, 2024
@daltonbohning daltonbohning added this to the Release 2.6.3 milestone Dec 11, 2024
@daltonbohning daltonbohning added release-2.6.3 Targeted for 2.6.3 clean-cherry-pick Cherry-pick from another branch that did not require additional edits labels Dec 11, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'githooks: support flake8>6'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16865

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 11, 2024
@daltonbohning
Copy link
Contributor Author

Can ignore the Version checking / Check for updates failure since that GHA will soon be removed in favor of dependabot

@daltonbohning daltonbohning marked this pull request as ready for review December 11, 2024 21:40
@daltonbohning daltonbohning requested a review from a team December 12, 2024 15:05
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 12, 2024
@daltonbohning daltonbohning merged commit 68b3a03 into release/2.6 Dec 12, 2024
38 of 42 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16865-2.6 branch December 12, 2024 15:06
@juszhan1 juszhan1 mentioned this pull request Dec 23, 2024
Closed
@mjmac mjmac mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

Assignees

@daltonbohning daltonbohning

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.6.3 Targeted for 2.6.3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daltonbohning @phender