Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16837 container: Add client-side DFS metrics (#15544) #15640

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Dec 18, 2024

If metrics are enabled for a POSIX container, create
a new pool/$UUID/container/$UUID/dfs metrics root in
the client telemetry to provide DFS-oriented metrics
(POSIX ops, file I/Os, etc).

Also fixes a bug in the agent code for pruning unused
client telemetry segments.

Required-githooks: true

Signed-off-by: Michael MacDonald [email protected]

Copy link

Ticket title is 'Add DFS-level metrics to client telemetry'
Status is 'Open'
https://daosio.atlassian.net/browse/DAOS-16837

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15640/1/testReport/

@mjmac mjmac force-pushed the mjmac/DAOS-16837-google-2.6 branch from f9493de to 50db9e2 Compare December 20, 2024 17:32
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15640/2/testReport/

@mjmac mjmac force-pushed the mjmac/DAOS-16837-google-2.6 branch from 50db9e2 to 70ad2a4 Compare December 31, 2024 12:33
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15640/3/testReport/

@mjmac mjmac force-pushed the mjmac/DAOS-16837-google-2.6 branch from 70ad2a4 to 1196fed Compare January 9, 2025 17:45
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15640/4/testReport/

@mjmac mjmac force-pushed the mjmac/DAOS-16837-google-2.6 branch from 1196fed to b612de7 Compare January 14, 2025 13:57
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15640/5/testReport/

@mjmac mjmac force-pushed the mjmac/DAOS-16837-google-2.6 branch from b612de7 to 46ccc2f Compare January 14, 2025 18:22
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15640/6/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Test RPMs on EL 8.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15640/6/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15640/6/execution/node/1168/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15640/7/execution/node/1221/log

johannlombardi and others added 3 commits January 15, 2025 17:05
This patch lays the ground work for adding support for snapshot to dfs in subsequent patches. It does not change anything from a functionality standpoint and just replaces all occurences of DAOS_TX_NONE in libdfs with dfs->th which can only be set to DAOS_TX_NONE for now.

A dfs::th_epoch field is added to the global dfs handle to record the epoch associated with the handle (can only be set to DAOS_EPOCH_MAX for now, which means DAOS_TX_NONE).

Signed-off-by: Johann Lombardi <[email protected]>
Co-authored-by: Mohamad Chaarawi <[email protected]>
If metrics are enabled for a POSIX container, create
a new pool/$UUID/container/$UUID/dfs metrics root in
the client telemetry to provide DFS-oriented metrics
(POSIX ops, file I/Os, etc).

Also fixes a bug in the agent code for pruning unused
client telemetry segments.

Required-githooks: true

Signed-off-by: Michael MacDonald <[email protected]>
These need to be reworked to be less fragile.

Signed-off-by: Michael MacDonald <[email protected]>
@mjmac mjmac force-pushed the mjmac/DAOS-16837-google-2.6 branch from 82ddfe2 to d186f75 Compare January 15, 2025 17:05
@mjmac mjmac requested review from jolivier23 and wangdi1 January 16, 2025 03:27
@mjmac mjmac merged commit b4e988d into google/2.6 Jan 17, 2025
49 of 52 checks passed
@mjmac mjmac deleted the mjmac/DAOS-16837-google-2.6 branch January 17, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants