DAOS-15630 test: tags.py dump tests associated with tags #15705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket title is 'ftest tag utility: ability to dump tests associated with tags' |
daltonbohning
force-pushed
the
dbohning/daos-15630
branch
2 times, most recently
from
61dc6ef to
555720b
Compare
Add support in tags.py to dump tests associated with tags and/or paths. Add TagSet to handle negative matching. E.g. foo,-bar Test-tag: always_passes Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning
force-pushed
the
dbohning/daos-15630
branch
from
555720b to
32d4359
Compare
daltonbohning
commented
Jan 9, 2025
Comment on lines
+172
to
+174
| # Convert to TagSet to handle negative matching | ||
| for idx, _tags in enumerate(tags): | ||
| tags[idx] = TagSet(_tags) |
There was a problem hiding this comment.
I considered using TagSet in the class itself so it's used everywhere, but we only really need negative matching for the user facing tools. And it does add a slight noticeable overhead to set operations, so I didn't want to slow down the core code
daltonbohning
commented
Jan 9, 2025
| @@ -470,14 +506,56 @@ def read_tag_config(): | |||
| return config | |||
|
|
|||
|
|
|||
| def run_list(paths): | |||
| def run_list(paths=None): | |||
There was a problem hiding this comment.
This function only prints tags, so it seemed strange to filter on tags
daltonbohning
commented
Jan 9, 2025
|
|
||
| if args.command == "dump": | ||
| run_dump(args.paths) | ||
| sys.exit(0) | ||
| return run_dump(args.paths, args.tags) | ||
|
|
||
| if args.command == "list": |
There was a problem hiding this comment.
Oops. I should put a check here
if args.tags:
print("--tags not supported with lint")
return 1
daltonbohning
commented
Jan 21, 2025
Comment on lines
+39
to
+40
| def issuperset(self, other): | ||
| return TagSet(other).issubset(self) |
There was a problem hiding this comment.
Maybe this is technically faster
Suggested change
| def issuperset(self, other): | |
| return TagSet(other).issubset(self) | |
| def issuperset(self, other): | |
| return TagSet.issubset(other, self) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support in tags.py to dump tests associated with tags and/or paths. Add TagSet to handle negative matching. E.g. foo,-bar
Test-tag: always_passes
Skip-unit-tests: true
Skip-fault-injection-test: true
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: