DAOS-15268 test: handle errors in add_del_user #15708
Open
+86
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket title is 'ftest add_del_user should fail on error' |
daltonbohning
force-pushed
the
dbohning/daos-15268
branch
from
09ff1e4 to
d799f02
Compare
Replace security_test_base.py:add_del_user with calls to individual functions and handle errors. Test-tag: SecurityPoolACLTest SecurityPoolGroupsTest DaosContainerSecurityTest Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning
force-pushed
the
dbohning/daos-15268
branch
from
d799f02 to
e73aec1
Compare
shimizukko
previously approved these changes
Jan 9, 2025
phender
requested changes
Jan 24, 2025
src/tests/ftest/util/user_utils.py
Outdated
| CommandResult: groups of command results from the same hosts with the same return status | ||
| """ | ||
| command = ' '.join(filter(None, [ | ||
| 'sudo -n' if sudo else None, |
There was a problem hiding this comment.
Don't you think it would make sense to standardize on using command_as_user() in situations like this?
src/tests/ftest/util/user_utils.py
Outdated
| CommandResult: groups of command results from the same hosts with the same return status | ||
| """ | ||
| command = ' '.join(filter(None, [ | ||
| 'sudo -n' if sudo else None, |
Comment on lines
+27
to
+28
| new_user: root | ||
| new_group: root |
There was a problem hiding this comment.
Does this now assume that the user account is pre-existing? If so, should we at least have a comment here?
There was a problem hiding this comment.
I think it's safe to assume root already exists
Test-tag: SecurityPoolACLTest SecurityPoolGroupsTest DaosContainerSecurityTest dfuse_mu Skip-unit-tests: true Skip-fault-injection-test: true Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace security_test_base.py:add_del_user with calls to individual functions and handle errors.
Test-tag: SecurityPoolACLTest SecurityPoolGroupsTest DaosContainerSecurityTest
Skip-unit-tests: true
Skip-fault-injection-test: true
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: