Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15698 test: Update the reset faulty device logic for nvme_utils.… #15755

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from

Conversation

phender
Copy link
Contributor

@phender phender commented Jan 21, 2025

…py (#15430)

MD-on-SSD cluster: If we set storage faulty, the corresponding engine dies (becomes excluded). Tell the server manager the rank is excluded and don't reset faulty device.
Non-MD-on-SSD cluster: Reset by calling dmg storage led identify --reset. We expect the command to work and all engines to be joined.

Test-tag: test_nvme_fault test_nvme_fault_reintegration test_vmd_led_faulty test_disk_failure_recover
Skip-func-hw-test-medium-vmd: false
Skip-func-hw-test-large-md-on-ssd: false

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

…py (#15430)

MD-on-SSD cluster: If we set storage faulty, the corresponding engine dies (becomes excluded). Tell the server manager the rank is excluded and don't reset faulty device.
Non-MD-on-SSD cluster: Reset by calling dmg storage led identify --reset. We expect the command to work and all engines to be joined.

Test-tag: test_nvme_fault test_nvme_fault_reintegration test_vmd_led_faulty test_disk_failure_recover
Skip-func-hw-test-medium-vmd: false
Skip-func-hw-test-large-md-on-ssd: false

Signed-off-by: Makito Kano <[email protected]>
@phender phender requested review from a team as code owners January 21, 2025 21:14
@phender phender requested a review from shimizukko January 21, 2025 21:14
@phender phender added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jan 21, 2025
Copy link

Ticket title is 'nvme/fault.py test fails on MD on SSD testing with KeyError.'
Status is 'Awaiting backport'
Labels: '2.6.0rc1,2.6.0rc3,2.6.1rc1,2.6.1rc2,2.6.2tb2,2.7.101tb,ci_2.6_weekly,ci_master_weekly,md_on_ssd,scrubbed_2.8,weekly_test'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-15698

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Jan 21, 2025
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codespell errors suggest maybe your release/2.6 was out of date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

3 participants