Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16978 vos: fix issue in VOS pool recreation on faulty device rep… #15771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DAOS-16978 vos: fix issue in VOS pool recreation on faulty device rep… #15771

wants to merge 1 commit into from

Conversation

junzeng1
Copy link
Collaborator

…lacing

Add a flag to identify the recreate operation in vos pool creation, and pass it to bio/smd module to avoid setting the SMD_POOL_IN_CREATION flag for recreation case in nvme disk replacing operation.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@junzeng1 junzeng1 requested review from a team as code owners January 23, 2025 02:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Ticket title is 'pool shard been deleted abnormally when daos service restart after doing nvme disk replace'
Status is 'In Review'
Labels: 'md_on_ssd'
https://daosio.atlassian.net/browse/DAOS-16978

NiuYawei
NiuYawei reviewed Jan 23, 2025
View reviewed changes
src/include/daos_srv/bio.h Outdated
@@ -1010,6 +1010,7 @@ int bio_copy(struct bio_io_context *ioctxt, struct umem_instance *umem,

enum bio_mc_flags {
BIO_MC_FL_RDB = (1UL << 0), /* for RDB */
BIO_MC_RE_CRE = (1UL << 1), /* to identify recreate (e.g., in replace op) */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could rename it to BIO_MC_FL_RECREATE?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix done.

wangshilong
wangshilong previously approved these changes Jan 23, 2025
View reviewed changes
sherintg
sherintg previously approved these changes Jan 24, 2025
View reviewed changes
@junzeng1
DAOS-16978 vos: fix issue in VOS pool recreation on faulty device rep…
91b0fc9 
…lacing

Add a flag to identify the recreate operation in vos pool creation, and pass it to
bio/smd module to avoid setting the SMD_POOL_IN_CREATION flag for recreation case in
nvme disk replacing operation.

Run-GHA: true

Signed-off-by: Jun Zeng <[email protected]>
@junzeng1 junzeng1 dismissed stale reviews from wangshilong and sherintg via 91b0fc9 January 24, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiuYawei NiuYawei NiuYawei left review comments

@sherintg sherintg sherintg left review comments

@wangshilong wangshilong wangshilong left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junzeng1 @wangshilong @NiuYawei @sherintg