fix wrong useEffect placement

daostack · Nov 9, 2023 · aca420c · aca420c
1 parent 57c2a54
commit aca420c
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/src/pages/common/components/FeedItem/FeedItem.tsx b/src/pages/common/components/FeedItem/FeedItem.tsx
@@ -78,6 +78,18 @@ const FeedItem = forwardRef<FeedItemRef, FeedItemProps>((props, ref) => {
   );
   useFeedItemSubscription(item.id, commonId, onFeedItemUpdate);
 
+  useEffect(() => {
+    if (
+      feedItemFollow.isUserFeedItemFollowDataFetched &&
+      !feedItemFollow.userFeedItemFollowData
+    ) {
+      onFeedItemUnfollowed?.(item.id);
+    }
+  }, [
+    feedItemFollow.isUserFeedItemFollowDataFetched,
+    feedItemFollow.userFeedItemFollowData,
+  ]);
+
   if (
     shouldCheckItemVisibility &&
     !checkIsItemVisibleForUser(
@@ -117,18 +129,6 @@ const FeedItem = forwardRef<FeedItemRef, FeedItemProps>((props, ref) => {
     onUserSelect,
   };
 
-  useEffect(() => {
-    if (
-      feedItemFollow.isUserFeedItemFollowDataFetched &&
-      !feedItemFollow.userFeedItemFollowData
-    ) {
-      onFeedItemUnfollowed?.(item.id);
-    }
-  }, [
-    feedItemFollow.isUserFeedItemFollowDataFetched,
-    feedItemFollow.userFeedItemFollowData,
-  ]);
-
   if (item.data.type === CommonFeedType.Discussion) {
     return <DiscussionFeedCard {...generalProps} />;
   }