Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open internal links in the app #2124

Closed
1 of 3 tasks
NoamQA opened this issue Sep 27, 2023 · 1 comment · Fixed by #2385
Closed
1 of 3 tasks

open internal links in the app #2124

NoamQA opened this issue Sep 27, 2023 · 1 comment · Fixed by #2385
Assignees
Labels
bug Something isn't working Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@NoamQA
Copy link
Collaborator

NoamQA commented Sep 27, 2023

Should start with:

Notice already regular internal links opens up in the app from the chat, we should use the same logic.

For the future:

  • Open Dynamic links in the app from the chat
  • Open Dynamic links in the app from the stream card
    (bug discussion here)
@NoamQA NoamQA added the bug Something isn't working label Sep 27, 2023
@elatif2020 elatif2020 changed the title some links doesn't open in the app open links in the app Nov 29, 2023
@elatif2020 elatif2020 changed the title open links in the app open internal links in the app Nov 30, 2023
@roienatan
Copy link
Collaborator

Regarding the first point: need to use the same logic we have in the chat. First use parseMessageLink to check whether it's an internal link and if so use onInternalLinkClick. Need to understand how to embed it within the react slate (editor) in the common about and the feed items description.

@roienatan roienatan linked a pull request Dec 6, 2023 that will close this issue
3 tasks
roienatan added a commit that referenced this issue Dec 19, 2023
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Dec 20, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority - B V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants