open internal links in the app #2124

[roienatan]

• PR title equals to the ticket name
• I added the ticket to the Development section of this PR.

What was changed?

• useOnInternalLinkClick hook that provides onInternalLinkClick ; use this hook in <Link /> in <TextEditor />.

[netlify]

✅ Deploy Preview for preview-common ready!

Name	Link
🔨 Latest commit	7a324d7
🔍 Latest deploy log	https://app.netlify.com/sites/preview-common/deploys/6580dd759d13bd0008bb1fa3
😎 Deploy Preview	https://deploy-preview-2385--preview-common.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[elatif2020]

@roienatan The app is crashing once I try to change the link (here with copy-paste). In DEV it doesn't happen
Edit: Also once pasting some links (to this deploy preview), e.g.: https://deploy-preview-2378--preview-common.netlify.app/commons/0fac27c8-b9f1-4969-a28c-a7d5d07ce91e?item=388aa3ac-62cb-4032-bfb1-186308dd46c1

Untitled.video.-.Made.with.Clipchamp.2.mp4

[elatif2020]

@roienatan The app is crashing once I try to change the link (here with copy-paste). In DEV it doesn't happen Edit: Also once pasting some links (to this deploy preview), e.g.: https://deploy-preview-2378--preview-common.netlify.app/commons/0fac27c8-b9f1-4969-a28c-a7d5d07ce91e?item=388aa3ac-62cb-4032-bfb1-186308dd46c1
Untitled.video.-.Made.with.Clipchamp.2.mp4

Anyway the above issue make it hard for me to test this feature

[roienatan]

@roienatan The app is crashing once I try to change the link (here with copy-paste). In DEV it doesn't happen Edit: Also once pasting some links (to this deploy preview), e.g.: https://deploy-preview-2385--preview-common.netlify.app/commons/0fac27c8-b9f1-4969-a28c-a7d5d07ce91e?item=388aa3ac-62cb-4032-bfb1-186308dd46c1

Untitled.video.-.Made.with.Clipchamp.2.mp4

Anyway the above issue make it hard for me to test this feature

@elatif2020 okay I'll try to reproduce and fix it. Thanks.

[roienatan]

@roienatan The app is crashing once I try to change the link (here with copy-paste). In DEV it doesn't happen Edit: Also once pasting some links (to this deploy preview), e.g.: https://deploy-preview-2378--preview-common.netlify.app/commons/0fac27c8-b9f1-4969-a28c-a7d5d07ce91e?item=388aa3ac-62cb-4032-bfb1-186308dd46c1
Untitled.video.-.Made.with.Clipchamp.2.mp4

Anyway the above issue make it hard for me to test this feature

@elatif2020 please try now.

[elatif2020]

@roienatan The app is crashing once I try to change the link (here with copy-paste). In DEV it doesn't happen Edit: Also once pasting some links (to this deploy preview), e.g.: https://deploy-preview-2378--preview-common.netlify.app/commons/0fac27c8-b9f1-4969-a28c-a7d5d07ce91e?item=388aa3ac-62cb-4032-bfb1-186308dd46c1
Untitled.video.-.Made.with.Clipchamp.2.mp4

Anyway the above issue make it hard for me to test this feature

@elatif2020 please try now.

@roienatan
I don't have the above issue now.
But now once I click on an internal link in the content of feed card (here is the test I used) it's both:

• Open a new tab with this link
• navigate to this link in the previous tab

This happens for the first link below, for the second (here) it just open another tab

Also, I see that if the content is just the link it's not showing up on the card (but it show up once I add more text)

[elatif2020]

@roienatan The app is crashing once I try to change the link (here with copy-paste). In DEV it doesn't happen Edit: Also once pasting some links (to this deploy preview), e.g.: https://deploy-preview-2378--preview-common.netlify.app/commons/0fac27c8-b9f1-4969-a28c-a7d5d07ce91e?item=388aa3ac-62cb-4032-bfb1-186308dd46c1
Untitled.video.-.Made.with.Clipchamp.2.mp4

Anyway the above issue make it hard for me to test this feature

@elatif2020 please try now.

@roienatan I don't have the above issue now. But now once I click on an internal link in the content of feed card (here is the test I used) it's both:

* Open a new tab with this link

* navigate to this link in the previous tab

This happens for the first link below, for the second (here) it just open another tab

Also, I see that if the content is just the link it's not showing up on the card (but it show up once I add more text)

I still have these issues

[elatif2020]

@roienatan The app is crashing once I try to change the link (here with copy-paste). In DEV it doesn't happen Edit: Also once pasting some links (to this deploy preview), e.g.: https://deploy-preview-2378--preview-common.netlify.app/commons/0fac27c8-b9f1-4969-a28c-a7d5d07ce91e?item=388aa3ac-62cb-4032-bfb1-186308dd46c1
Untitled.video.-.Made.with.Clipchamp.2.mp4

Anyway the above issue make it hard for me to test this feature

@elatif2020 please try now.

@roienatan I don't have the above issue now. But now once I click on an internal link in the content of feed card (here is the test I used) it's both:

* Open a new tab with this link

* navigate to this link in the previous tab

This happens for the first link below, for the second (here) it just open another tab
Also, I see that if the content is just the link it's not showing up on the card (but it show up once I add more text)

I still have these issues

It's now good from my side 🙏