Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the messages action menu on tap outside it \ on scroll #2146

Closed
elatif2020 opened this issue Oct 5, 2023 · 3 comments · Fixed by #2244
Closed

Hide the messages action menu on tap outside it \ on scroll #2146

elatif2020 opened this issue Oct 5, 2023 · 3 comments · Fixed by #2244
Labels
chat Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

No description provided.

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 25, 2023

@budnik9
See this screen recording:

video1619208741.mp4
  • When using right click there is a jump once the cursor leave the message bubble (and the dropdown arrow disappears). Could we avoid this? Maybe by keeping the arrow visible if the menu is open?

  • When using the dropdown arrow the menu disappears once the cursor leave the menu. Could be better to keep it visible as long as the user doesn't scroll or click somewhere outside.

  • Not sure if it the same issue but anyway maybe you can fix it together: on messages in Hebrew (RTL) the alignment of the text and icons in the menu is opposite and doesn't look good. It should stay the same.

Image

Image

pvm-code added a commit that referenced this issue Oct 25, 2023
Hide the messages action menu on tap outside it \ on scroll #2146
@budnik9
Copy link
Contributor

budnik9 commented Oct 25, 2023

@elatif2020 Most of points you mentioned are not related this ticket. Could you please create a new ticket with these changes?
Moreover, Pavel has already closed this task

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 25, 2023

Ok, right, got you @budnik9
#2245

@NoamQA NoamQA added the V [production] verified on production enviroment label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants