Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide the messages action menu on tap outside it \ on scroll #2146 #2244

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Hide the messages action menu on tap outside it \ on scroll #2146 #2244

merged 1 commit into from
Oct 25, 2023

Conversation

budnik9
Copy link
Contributor

@budnik9 budnik9 commented Oct 24, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • Added menu closing behavior on chat scrolling
  • If there is not enough space for the message menu, it will be displayed on top of the message

@budnik9 budnik9 self-assigned this Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 5c7cad7
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/6538318615d6c100081e2891
😎 Deploy Preview https://deploy-preview-2244--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@budnik9 budnik9 linked an issue Oct 24, 2023 that may be closed by this pull request
Hide the messages action menu on tap outside it \ on scroll #2146
Closed
@pvm-code pvm-code merged commit 1b4e27b into dev Oct 25, 2023
@pvm-code pvm-code deleted the feature/CW-2146-hide-message-menu branch October 25, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvm-code pvm-code pvm-code approved these changes

@andreymikhadyuk andreymikhadyuk Awaiting requested review from andreymikhadyuk

@roienatan roienatan Awaiting requested review from roienatan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide the messages action menu on tap outside it \ on scroll
2 participants
@budnik9 @pvm-code