Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(re)Show "join common" button in about page (for root common) #2217

Closed
NoamQA opened this issue Oct 19, 2023 · 1 comment · Fixed by #2219
Closed

(re)Show "join common" button in about page (for root common) #2217

NoamQA opened this issue Oct 19, 2023 · 1 comment · Fixed by #2219
Assignees
@roienatan
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@NoamQA
Copy link
Collaborator

NoamQA commented Oct 19, 2023 •
edited by elatif2020
Loading

We had this button before. Need to show it back only for root common (and not for sub-spaces).

currently:
when i open a space with a link it opens the about page of the space
there is a link there to join the parent common
the link opens the about page of the common
and there is no button there to join the common
or to open the front page of it

Image

Image
@elatif2020 elatif2020 changed the title there is no "join a common" button in about page Add "join common" button in about page (for root common) Oct 19, 2023
@elatif2020 elatif2020 removed their assignment Oct 19, 2023
@elatif2020 elatif2020 changed the title Add "join common" button in about page (for root common) (re)Show "join common" button in about page (for root common) Oct 19, 2023
@roienatan roienatan linked a pull request Oct 19, 2023 that will close this issue
(re)Show "join common" button in about page (for root common) #2217 #2219
Merged
5 tasks
@NoamQA
Copy link
Collaborator Author

NoamQA commented Oct 25, 2023

✅ works fine in deploy preview env.

roienatan added a commit that referenced this issue Oct 25, 2023
@roienatan
Merge pull request #2219 from daostack/cw-2217-about-root-common-join…
8d633f9 
…-button

(re)Show "join common" button in about page (for root common) #2217
@NoamQA NoamQA added V [dev] verified on dev enviroment V [production] verified on production enviroment labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roienatan roienatan

Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(re)Show "join common" button in about page (for root common) #2217 daostack/common-web
4 participants
@budnik9 @roienatan @elatif2020 @NoamQA