(re)Show "join common" button in about page (for root common) #2217

[roienatan]

• PR title equals to the ticket name
• I added the ticket to the Development section of this PR.

What was changed?

• about page root common: show join common button
• CommonTopNavigation and MembershipRequestIntroduce join button are now pink (instead of old purple design)
• "Join via" is now a button and not a link.

[netlify]

✅ Deploy Preview for preview-common ready!

Name	Link
🔨 Latest commit	14c3192
🔍 Latest deploy log	https://app.netlify.com/sites/preview-common/deploys/653687b49a71e9000814ee06
😎 Deploy Preview	https://deploy-preview-2219--preview-common.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[roienatan]

Need to verify the below things: @andreymikhadyuk

• I'm not sure we use or need withJoinRequest at all. See in src/pages/common/components/CommonTabPanels/components/AboutTab/components/CommonEntranceInfo/components/CommonEntranceJoin/CommonEntranceJoin.tsx
• Why do we need rootCommonMember and parentCommonMember for isJoinAllowed in src/pages/common/providers/CommonData/CommonData.tsx? They are null when a user is not member of the common hence isJoinAllowed is false so I had to remove them. I don't understand why we need this.

[andreymikhadyuk]

@roienatan

1. I see that withJoinRequest is in use, why do we need to remove it?
2. I think you are correct and we also should update isProject && parentCommonMember && !commonMember to isProject && rootCommonMember && parentCommonMember && !commonMember. @elatif2020 Am I correct that we should allow join in project only when we are a member of root and parent commons?

[elatif2020]

@roienatan

1. I see that `withJoinRequest` is in use, why do we need to remove it?

2. I think you are correct and we also should update `isProject && parentCommonMember && !commonMember` to `isProject && rootCommonMember && parentCommonMember && !commonMember`. @elatif2020 Am I correct that we should allow join in project only when we are a member of root and parent commons?

2 - yes it is correct (for now)

[roienatan]

@roienatan

1. I see that withJoinRequest is in use, why do we need to remove it?
2. I think you are correct and we also should update isProject && parentCommonMember && !commonMember to isProject && rootCommonMember && parentCommonMember && !commonMember. @elatif2020 Am I correct that we should allow join in project only when we are a member of root and parent commons?

@andreymikhadyuk specifically in CommonEntranceJoin it's not in use now, at least I don't see the use of it.

[andreymikhadyuk]

@roienatan

1. I see that withJoinRequest is in use, why do we need to remove it?
2. I think you are correct and we also should update isProject && parentCommonMember && !commonMember to isProject && rootCommonMember && parentCommonMember && !commonMember. @elatif2020 Am I correct that we should allow join in project only when we are a member of root and parent commons?

@andreymikhadyuk specifically in CommonEntranceJoin it's not in use now, at least I don't see the use of it.

[roienatan]

@roienatan

1. I see that withJoinRequest is in use, why do we need to remove it?
2. I think you are correct and we also should update isProject && parentCommonMember && !commonMember to isProject && rootCommonMember && parentCommonMember && !commonMember. @elatif2020 Am I correct that we should allow join in project only when we are a member of root and parent commons?

@andreymikhadyuk specifically in CommonEntranceJoin it's not in use now, at least I don't see the use of it.

@andreymikhadyuk I know I removed it, but I'm not sure about the purpose of this. I reverted it anyway.