Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffrentitate between a "new" item and an item marked "unseen" #2221

Closed
elatif2020 opened this issue Oct 20, 2023 · 3 comments
Closed

Diffrentitate between a "new" item and an item marked "unseen" #2221

elatif2020 opened this issue Oct 20, 2023 · 3 comments
Assignees
Labels
high priority V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 20, 2023

We should have different appearance in the FE for items which are "new" for a user and items which were marked as unread.
Currently what I see is:

  • "new" items don't have a badge (for other users) before a message is sent.
  • once a message is sent in a "new" item it appears with "mark unseen" badge instead as new.

I'm not sure whether the issue is in the FE or BE. currently opening in the BE, but could be good if also someone from the FE could have a look.

@danielr18
Copy link
Collaborator

The commonFeedObjectUserUnique object has seen and seenOnce. If seen is false, then it's unread. If seenOnce is false, then it's new.

@danielr18 danielr18 transferred this issue from another repository Oct 21, 2023
@budnik9
Copy link
Contributor

budnik9 commented Oct 23, 2023

@danielr18 The problem is that the backend returns wrong values of these flags.
For example, I have two users User 1 and User 2

  1. User 1 creates a discussion in a space.
  2. User 2 opens this space and sees newly created discussion but without New tag, because the seenOnce flag value is true

image

Also there is one more strange behavior:
If User 1 writes a message in this discussion, User 2 will see unseen tag on the discussion. And that's a data problem, too (count is 0, seen is false, seenOnce is undefined).

image

cc @elatif2020

@elatif2020
Copy link
Collaborator Author

elatif2020 commented Oct 25, 2023

If I understand correctly this issue was taken care of from the BE side in #2233 and was transferred to the FE.
So I am closing current ticket as a duplication.

@elatif2020 elatif2020 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority V [production] verified on production enviroment
Projects
None yet
Development

No branches or pull requests

7 participants