Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct seen \ seenOnce default values #2233

Closed
elatif2020 opened this issue Oct 23, 2023 · 7 comments · Fixed by #2251
Closed

Correct seen \ seenOnce default values #2233

elatif2020 opened this issue Oct 23, 2023 · 7 comments · Fixed by #2251
Labels
Priority - A V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 23, 2023

seen & seenOnce defaults for other users should be false

          @danielr18 The problem is that the backend returns wrong values of these flags.

For example, I have two users User 1 and User 2

  1. User 1 creates a discussion in a space.
  2. User 2 opens this space and sees newly created discussion but without New tag, because the seenOnce flag value is true

image

Also there is one more strange behavior:
If User 1 writes a message in this discussion, User 2 will see unseen tag on the discussion. And that's a data problem, too (count is 0, seen is false, seenOnce is undefined).

image

cc @elatif2020

Originally posted by @budnik9 in #2221 (comment)

@elatif2020 elatif2020 changed the title Correct seen \ seenOnce in values Correct seen \ seenOnce default values Oct 23, 2023
@danielr18 danielr18 transferred this issue from another repository Oct 24, 2023
@danielr18 danielr18 assigned budnik9 and unassigned danielr18 Oct 24, 2023
@danielr18
Copy link
Collaborator

Hi @budnik9. I've made the changes in the backend.

However, we need to make a change in the frontend to treat a missing commonFeedObjectUserUnique for the user as New.

@budnik9
Copy link
Contributor

budnik9 commented Oct 26, 2023

@elatif2020 @danielr18 Please confirm if this behavior is correct!

For example, I have two users User 1 and User 2

User 1 creates a discussion in a space.
User 2 opens this space and sees newly created discussion with New tag
User 1 writes a message in this discussion
User 2 still sees New tag on the discussion (not counter with 1 unread message).

commonFeedObjectUserUnique state at this moment:

image

@elatif2020
Copy link
Collaborator Author

@elatif2020 @danielr18 Please confirm if this behavior is correct!

For example, I have two users User 1 and User 2

User 1 creates a discussion in a space. User 2 opens this space and sees newly created discussion with New tag User 1 writes a message in this discussion User 2 still sees New tag on the discussion (not counter with 1 unread message).

commonFeedObjectUserUnique state at this moment:

image

@budnik9
Yes this is correct
Counter starts only after the item is no longer new

@budnik9 budnik9 linked a pull request Oct 26, 2023 that will close this issue
3 tasks
@budnik9
Copy link
Contributor

budnik9 commented Oct 26, 2023

@danielr18 I made changes to treat a missing commonFeedObjectUserUnique for the user as New. Now it should work as expected.
But when User 1 writes messages in the discussion, User 2 doesn't see unread messages counter, because commonFeedObjectUserUnique is not updated. I'm not sure if we already have a ticket for this issue.
cc @elatif2020

@elatif2020
Copy link
Collaborator Author

@budnik9 I'm not sure whether this is an issue or the correct behavior. Does it happens also after User 2 see the item?
We decided anyway not to show both a counter and new indication at the same time.

@budnik9
Copy link
Contributor

budnik9 commented Oct 26, 2023

@elatif2020 It happens after User 2 sees the item
User 2 sees the item. New tag disappears. User 2 go to another item (for example Home)
User 1 writes the message in the newly created discussion
User 2 doesn't see the unread messages counter on this discussion

@elatif2020
Copy link
Collaborator Author

@elatif2020 It happens after User 2 sees the item User 2 sees the item. New tag disappears. User 2 go to another item (for example Home) User 1 writes the message in the newly created discussion User 2 doesn't see the unread messages counter on this discussion

@budnik9 okay thanks for clarifying, I created a BE ticket https://github.com/daostack/common-backend/issues/2196

pvm-code added a commit that referenced this issue Oct 26, 2023
…ity-issue

Correct seen \ seenOnce default values #2233
@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [production] verified on production enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants