Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the inbox items avatars clickable #2240

Closed
elatif2020 opened this issue Oct 24, 2023 · 2 comments · Fixed by #2274
Closed

Make the inbox items avatars clickable #2240

elatif2020 opened this issue Oct 24, 2023 · 2 comments · Fixed by #2274
Assignees
@roienatan
Labels
Priority - B V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Oct 24, 2023 •
edited
Loading

Navigate to the relevant space upon clicking the avatar of a stream (space).
Open the user profile in the right pane upon clicking the avatar of a user.
Also for the mobile (and actually maybe better to start with the mobile, it's more important there).

Image
@roienatan roienatan changed the title Make the inbox items Avatars clickable Make the inbox items avatars clickable Oct 30, 2023
@roienatan roienatan linked a pull request Oct 30, 2023 that will close this issue
Make the inbox items avatars clickable #2240 #2274
Merged
3 tasks
andreymikhadyuk added a commit that referenced this issue Nov 7, 2023
@andreymikhadyuk
Merge pull request #2274 from daostack/cw-2240-inbox-items-avatar-cli…
4a38a0e 
…ckable

Make the inbox items avatars clickable #2240
@NoamQA
Copy link
Collaborator

NoamQA commented Nov 14, 2023

@elatif2020
when there is a discussion item it opens the common/space of it
and not the discussion itself
is it OK for us?

@elatif2020
Copy link
Collaborator Author

@elatif2020 when there is a discussion item it opens the common/space of it and not the discussion itself is it OK for us?

yes this is the intention

@NoamQA NoamQA added the V [production] verified on production enviroment label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roienatan roienatan

Labels
Priority - B V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the inbox items avatars clickable #2240 daostack/common-web
6 participants
@andreymikhadyuk @budnik9 @roienatan @pvm-code @elatif2020 @NoamQA