Make the inbox items avatars clickable #2240 #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preview-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreymikhadyuk
requested changes
Oct 31, 2023
| alt={imageAlt} | ||
| /> | ||
| )} | ||
| <div onClick={handleAvatarClick}> |
There was a problem hiding this comment.
I would move click handler outside of this component to the parents which use it and pass the callback as onImageClick prop. So the component at least will not know about the dm user and such kind of things which are not related to the component itself.
There was a problem hiding this comment.
@andreymikhadyuk I'm not sure I understood what's the issue with that. Currently the handleAvatarClick is only being used there, and data like dmUserId is necessary for this. So if it's being used only here, why should we define the function outside and pass it by props...
andreymikhadyuk
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developmentsection of this PR.What was changed?