Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL fixes in the chat #2300

Closed
1 task done
elatif2020 opened this issue Nov 7, 2023 · 2 comments · Fixed by #2383 or #2408
Closed
1 task done

RTL fixes in the chat #2300

elatif2020 opened this issue Nov 7, 2023 · 2 comments · Fixed by #2383 or #2408
Assignees
@roienatan
Labels
bug Something isn't working V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Nov 7, 2023 •
edited by roienatan
Loading

  • Text direction should stay LTR (if it was LTR) when mentioning a RTL userName (Hebrew)

Image

Archive
This "Loading..." should be LTR also if the message is RTL (removed with the pagination)

Image
@elatif2020 elatif2020 added bug Something isn't working Priority - B labels Nov 7, 2023
@roienatan
Copy link
Collaborator

roienatan commented Nov 28, 2023 •
edited
Loading

@elatif2020 Regarding the first point: This "Loading..." should be LTR also if the message is RTL - seems like we eliminated the "Loading..." text in the chat pagination PR so it's not relevant anymore.

@roienatan roienatan linked a pull request Dec 5, 2023 that will close this issue
RTL fixes in the chat #2300 #2383
Merged
3 tasks
@elatif2020
Copy link
Collaborator Author

This fix looks good to me

roienatan added a commit that referenced this issue Dec 13, 2023
@roienatan
Merge pull request #2383 from daostack/cw-2300-fix-chat-messages-rtl
c111c2b 
RTL fixes in the chat #2300
@roienatan roienatan mentioned this issue Dec 19, 2023
Merged
4 tasks
@roienatan roienatan linked a pull request Dec 19, 2023 that will close this issue
Handle rtl text better in chat messages #2408
Merged
4 tasks
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Dec 19, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roienatan roienatan

Labels
bug Something isn't working V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
Milestone
No milestone
3 participants
@roienatan @elatif2020 @NoamQA