Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL fixes in the chat #2300 #2383

Merged
merged 3 commits into from
Dec 13, 2023
Merged

RTL fixes in the chat #2300 #2383

merged 3 commits into from
Dec 13, 2023

Conversation

roienatan
Copy link
Collaborator

@roienatan roienatan commented Dec 5, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • in isRtlText: filter mentions in the text to ignore mentions text and check only message content characters.

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 7d1cfe2
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/656f764358a3b70008aace90
😎 Deploy Preview https://deploy-preview-2383--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roienatan roienatan linked an issue Dec 5, 2023 that may be closed by this pull request
1 task
@roienatan
Copy link
Collaborator Author

roienatan commented Dec 5, 2023

For now I'm using untyped parsed text. When I try to use parseStringToTextEditorValue I keep getting the below error and the app crashes.

Screenshot 2023-12-05 at 12 31 38

@roienatan roienatan changed the title in isRtlText: filter mentions in the text to ignore mentions text and… RTL fixes in the chat #2300 Dec 7, 2023
@roienatan roienatan marked this pull request as ready for review December 11, 2023 05:39
@roienatan roienatan merged commit c111c2b into dev Dec 13, 2023
4 of 5 checks passed
@roienatan roienatan deleted the cw-2300-fix-chat-messages-rtl branch December 13, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTL fixes in the chat
2 participants