Fix to focus on the current space in the sidebar

[elatif2020]

• When navigating to spaces in the first time, and in some other scenarios I find out the sidebar focus is in a different common.
  It should always focus on the common which is active (according to the item I came from)
  Steps to reproduce:
  1 - Make sure to follow this discussion
  2 - Navigate to another common
  3 - Navigate to the inbox,
  4 - Find and click the item Autumn DEV
  5 - Click on the "Boots" space in the system message
  6 - In the sidebar your other common is appearing
  This happens both in mobile and desktop
  Here is an example where I was in another space and reached different common in the sidebar
  

• Another related issue: the sidebar spaces tree is unable to focus on spaces that are deeper than the second level when you go directly to the space (via a url). It might be the problem you described here.
  To clarify, given this structure:
  A (Main common)
  B (space under A)
  C (space under B)
  If you take the url of A or B the tree will be auto-focused as expected including opening the tree automatically. But if you try with C url, the tree stays close.
  Happens both on mobile and desktop.

[roienatan]

@elatif2020 I'm not sure I can reproduced exactly what you described but I have discovered that the recursive tree is unable to focus on spaces that are deeper then the second level when you go directly to the space (via a url). It might be the problem you described here.
To clarify, given this structure:
A (Main common)
B (space under A)
C (space under B)
If you take the url of A or B the tree will be auto-focused as expected including opening the tree automatically. But if you try with C url, the tree stays close.

By the way, the issue I've described happens both on mobile and desktop.

[elatif2020]

@elatif2020 I'm not sure I can reproduced exactly what you described but I have discovered that the recursive tree is unable to focus on spaces that are deeper then the second level when you go directly to the space (via a url). It might be the problem you described here. To clarify, given this structure: A (Main common) B (space under A) C (space under B) If you take the url of A or B the tree will be auto-focused as expected including opening the tree automatically. But if you try with C url, the tree stays close.

By the way, the issue I've described happens both on mobile and desktop.

@roienatan
Okay this is another issue that we should also take care of. I was able to reproduce it.
Steps to reproduce the issue I had:
1 - Make sure to follow this discussion
2 - Navigate to another common
3 - Navigate to the inbox,
4 - Find and click the item Autumn DEV
5 - Click on the "Boots" space in the system message
6 - In the sidebar your other common is appearing

This also happens both in mobile and desktop

[elatif2020]

I updated this card info with both issues

[NoamQA]

@roienatan @elatif2020
retested it
still happens in dev+web stage

i open a common and see it in the sidebar
open inbox and fine a stream with a system message of creating a common
when i click the common name it opens
and in the sidebar there is the first common that was before

[andreymikhadyuk]

@NoamQA I think the issue is with these specific commons: ttt and rrr. ttt has direct parent 0c4fca76-5a44-442c-9c74-41389a15b5aa, but this direct parent has state INACTIVE (its name is new). Did you remove that common?

[elatif2020]

I can't reproduce it so I guess it is a special case with some issue in the data

[NoamQA]

@andreymikhadyuk @elatif2020
yes it works fine now