Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to focus on the current space in the sidebar #2335 #2425

Merged
merged 3 commits into from
Dec 26, 2023
Merged

Fix to focus on the current space in the sidebar #2335 #2425

merged 3 commits into from
Dec 26, 2023

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Dec 26, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • created action to reset sidenav's current common id and projects
  • fixed current space focus on system message click
  • fixed opening of the deep nested spaces

@netlify Netlify
Copy link

netlify bot commented Dec 26, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit d488387
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/658ab30da3f3030008273c92
😎 Deploy Preview https://deploy-preview-2425--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk linked an issue Dec 26, 2023 that may be closed by this pull request
Fix to focus on the current space in the sidebar #2335
Closed
2 tasks
@andreymikhadyuk andreymikhadyuk marked this pull request as ready for review December 26, 2023 11:06
@andreymikhadyuk andreymikhadyuk merged commit abfb9d8 into dev Dec 26, 2023
5 checks passed
@andreymikhadyuk andreymikhadyuk deleted the bugfix/CW-2335-current-space-focus branch December 26, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnik9 budnik9 budnik9 approved these changes

@roienatan roienatan Awaiting requested review from roienatan

@pvm-code pvm-code Awaiting requested review from pvm-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix to focus on the current space in the sidebar
2 participants
@andreymikhadyuk @budnik9