Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE usage of the inbox subcollection #2363

Closed
elatif2020 opened this issue Nov 29, 2023 · 3 comments · Fixed by #2378
Closed

FE usage of the inbox subcollection #2363

elatif2020 opened this issue Nov 29, 2023 · 3 comments · Fixed by #2378
Assignees
Labels
Priority - A V [dev] verified on dev enviroment

Comments

@elatif2020
Copy link
Collaborator

Currently the FE is subscribing to the feedItemFollows subscollection and skipping the inbox subcollection.
However they are different and will be different especially once we start using the linked streams feature.
So we should change to subscribing the inbox subcollection instead.
If needed we might ask the BE to add additional information there to make the loading more efficient.

@elatif2020
Copy link
Collaborator Author

@andreymikhadyuk @danielr18 we can discuss additional details here

@andreymikhadyuk
Copy link
Collaborator

We need to change useInboxItems hook to start subscribing directly to the inbox items instead of feed item follow and chat channels. I do not think that something should be done from the BE side here.

@andreymikhadyuk
Copy link
Collaborator

@danielr18 I get such error when trying to subscribe to inbox collection or trying to get data from that collection:
image

Here are the methods I use.

@andreymikhadyuk andreymikhadyuk linked a pull request Dec 4, 2023 that will close this issue
4 tasks
andreymikhadyuk added a commit that referenced this issue Dec 18, 2023
…on-usage

FE usage of the inbox subcollection #2363
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [dev] verified on dev enviroment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants