Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE usage of the inbox subcollection #2363 #2378

Merged
merged 18 commits into from
Dec 18, 2023
Merged

FE usage of the inbox subcollection #2363 #2378

merged 18 commits into from
Dec 18, 2023

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Dec 4, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • updated InboxItem model with latest version
  • changed the logic of useInboxItems to start using inbox collection as a base, not feed item follow and chat channel related collections

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit c351c22
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/658015a19a3428000838913a
😎 Deploy Preview https://deploy-preview-2378--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk linked an issue Dec 4, 2023 that may be closed by this pull request
FE usage of the inbox subcollection #2363
Closed
@andreymikhadyuk andreymikhadyuk marked this pull request as ready for review December 4, 2023 10:52
@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 You can check the PR again.

@elatif2020
Copy link
Collaborator

@elatif2020 You can check the PR again.

it's good for me so far

@andreymikhadyuk andreymikhadyuk marked this pull request as draft December 5, 2023 12:37
@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 It is better to wait on merging this ticket because current updatedAt field is not what we actually need and we need to wait for Daniel's changes for inbox collection, so we will have proper dates for sorting and subscriptions.

@andreymikhadyuk andreymikhadyuk force-pushed the feature/CW-2363-inbox-collection-usage branch from 742d962 to 47ed4b3 Compare December 11, 2023 10:19
@roienatan roienatan mentioned this pull request Dec 17, 2023
Merged
3 tasks
@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 Please play a bit with inbox usual and unread version. If everything is fine I will merge it.

@andreymikhadyuk andreymikhadyuk marked this pull request as ready for review December 18, 2023 08:46
@elatif2020
Copy link
Collaborator

@elatif2020 Please play a bit with inbox usual and unread version. If everything is fine I will merge it.

@andreymikhadyuk
The unread inbox displays also read items
image

@elatif2020
Copy link
Collaborator

@elatif2020 Please play a bit with inbox usual and unread version. If everything is fine I will merge it.

@andreymikhadyuk The unread inbox displays also read items image

@andreymikhadyuk
Read items in the unread list examples:
https://web-dev.common.io/commons/4c87126a-d764-42c5-90dc-723431fa5a46?item=ccb25df2-410b-46b1-8c28-552bb4957326
https://web-dev.common.io/commons/a977dbb7-92bc-46e6-a600-ae6c834d589a?item=d9c89bee-f177-4c13-94de-99f5a57fd6fe
https://web-dev.common.io/commons/4c87126a-d764-42c5-90dc-723431fa5a46?item=02437f25-0d3d-4d61-b380-bca563ede958

@andreymikhadyuk andreymikhadyuk merged commit 85413f2 into dev Dec 18, 2023
5 checks passed
@andreymikhadyuk andreymikhadyuk deleted the feature/CW-2363-inbox-collection-usage branch December 18, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnik9 budnik9 budnik9 approved these changes

@roienatan roienatan Awaiting requested review from roienatan

@pvm-code pvm-code Awaiting requested review from pvm-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE usage of the inbox subcollection
3 participants
@andreymikhadyuk @elatif2020 @budnik9