Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group message in the inbox #2380

Closed
9 tasks done
elatif2020 opened this issue Dec 4, 2023 · 4 comments · Fixed by #2386 or #2436
Closed
9 tasks done

Group message in the inbox #2380

elatif2020 opened this issue Dec 4, 2023 · 4 comments · Fixed by #2386 or #2436
Assignees
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment

Comments

@elatif2020
Copy link
Collaborator

elatif2020 commented Dec 4, 2023

Creation flow: like DMs but with more than 2 people

  • Only from within the inbox, start new Group message - design here
  • Choose people from a dropdown: like DM but let you choose more than 1, see designs
  • Add selected names in the search line as tags, and add v next to selected user
  • Input line should be expanded to several lines if needed.
  • Create button should create a new group chat with those users (and the creator) if it doesn't exist,
  • Or, if such a group chat exists show the existing group chat item in the inbox

Show group chat items in the inbox, similar to direct messages, design

  • People avatar for any group
  • Title: list private names of other members of this group
  • On creation the last messages preview text should be "$useName created this group chat"

  • Simplifications: currently no admin, no unfollow or leave, no option to delete group (we will add those in the future)
@roienatan roienatan self-assigned this Dec 8, 2023
@roienatan roienatan linked a pull request Dec 8, 2023 that will close this issue
3 tasks
@roienatan
Copy link
Collaborator

roienatan commented Dec 13, 2023

@elatif2020

  1. As discussed, for now we don't support mentioning a user in a group chat.
  2. Regarding duplicated items in inbox when trying to create a chat that already exists: so actually the issue exists also in dev (to reproduce: try to create a direct message of the same user twice or more one after another). So this is needed to be solved in a separate ticket. Do we have a ticket for this?
  3. For group chats we show only the first name of the users.
  4. I've added title prop to the inbox feed item title, so when you hover the default browser popup is displayed with the whole title text.

@NoamQA
Copy link
Collaborator

NoamQA commented Dec 25, 2023

@elatif2020 @roienatan
❌ group doesent appear in other users inbox
only in the creator inbox

Image

❌ group name in the inbox bread cramp contain only 1 of the group members

Image

@NoamQA NoamQA reopened this Dec 25, 2023
@roienatan
Copy link
Collaborator

@NoamQA regarding the first point group doesn't appear in other users inbox only in the creator inbox it should be good now, it was cache related. Please verify again 🙏

@NoamQA
Copy link
Collaborator

NoamQA commented Dec 26, 2023

@roienatan
works fine now!!

@roienatan roienatan linked a pull request Dec 27, 2023 that will close this issue
4 tasks
roienatan added a commit that referenced this issue Dec 28, 2023
@NoamQA NoamQA added the V [dev] verified on dev enviroment label Dec 29, 2023
@NoamQA NoamQA added the V [production] verified on production enviroment label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority - A V [dev] verified on dev enviroment V [production] verified on production enviroment
Projects
None yet
3 participants