Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group message in the inbox #2380 #2386

Merged
merged 27 commits into from
Dec 20, 2023
Merged

Group message in the inbox #2380 #2386

merged 27 commits into from
Dec 20, 2023

Conversation

roienatan
Copy link
Collaborator

@roienatan roienatan commented Dec 8, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • Support group message. See ticket for full details.

@roienatan roienatan linked an issue Dec 8, 2023 that may be closed by this pull request
Group message in the inbox #2380
Closed
9 tasks
@netlify Netlify
Copy link

netlify bot commented Dec 8, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit dac849b
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/65822667d41be0000855123d
😎 Deploy Preview https://deploy-preview-2386--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elatif2020
Copy link
Collaborator

@roienatan
There is a crash after trying to create a group message
But it might also be related to the changes @andreymikhadyuk and @danielr18 made regarding using the inbox collection
image

@elatif2020
Copy link
Collaborator

@roienatan
Notice also my comment in common

@roienatan
Copy link
Collaborator Author

regarding using the inbox c

@elatif2020 does it always happen to you? I can't reproduce at my side.
Anyway, I can merge this PR to my PR but I see it's still in draft.

@roienatan roienatan marked this pull request as ready for review December 18, 2023 13:20
@elatif2020
Copy link
Collaborator

It's good from my side
So I guess it's pending a review from one of you
@andreymikhadyuk @budnik9 @MeyerPV

@roienatan roienatan requested a review from budnik9 December 19, 2023 23:22
@roienatan roienatan merged commit 296f948 into dev Dec 20, 2023
5 checks passed
@roienatan roienatan deleted the cw-2380-support-group-message branch December 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elatif2020 elatif2020 elatif2020 left review comments

@budnik9 budnik9 budnik9 approved these changes

@andreymikhadyuk andreymikhadyuk Awaiting requested review from andreymikhadyuk

@pvm-code pvm-code Awaiting requested review from pvm-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group message in the inbox
3 participants
@roienatan @elatif2020 @budnik9