Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRODUCTION - Infinite loading for discussions#2228 #2229

Closed
wants to merge 1 commit into from
Closed

PRODUCTION - Infinite loading for discussions#2228 #2229

wants to merge 1 commit into from

Conversation

pvm-code
Copy link
Collaborator

#2228

What was changed?

  • Added check for discussionId

@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 412cf0b
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/65364d67b5c1220008e869e1
😎 Deploy Preview https://deploy-preview-2229--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pvm-code pvm-code linked an issue Oct 23, 2023 that may be closed by this pull request
PRODUCTION - Infinite loading for discussions #2228
Closed
andreymikhadyuk
andreymikhadyuk requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we were discussing, we should not solve this issue by wrapping the calls in if. The error is somewhere deeper, maybe with the data.

@andreymikhadyuk
Copy link
Collaborator

@MeyerPV @elatif2020 Is this same as #2286?

@elatif2020
Copy link
Collaborator

@MeyerPV @elatif2020 Is this same as #2286?

Not sure, maybe @MeyerPV can say

@andreymikhadyuk andreymikhadyuk deleted the CW-2228-production-infinite-loading-discussions branch November 14, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreymikhadyuk andreymikhadyuk andreymikhadyuk requested changes

@roienatan roienatan roienatan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PRODUCTION - Infinite loading for discussions
4 participants
@pvm-code @andreymikhadyuk @elatif2020 @roienatan