Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages action menu issues #2245 #2279

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Messages action menu issues #2245 #2279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c01cf4b
display chat message arrow when menu is open
andreymikhadyuk Oct 31, 2023
72fa5ae
make chat message menu to be always in ltr direction
andreymikhadyuk Oct 31, 2023
00ed70f
Merge branch 'dev' into bugfix/CW-2245-chat-message-menu
andreymikhadyuk Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/shared/components/Chat/ChatMessage/ChatMessage.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,17 @@
}
}

.elementDropdownMenu {
direction: ltr;
}

.menuArrowButton {
display: none;
}
.menuArrowButtonVisible {
display: block;
}

.messageTextWithReply {
padding: 0.25rem 0rem 0.5rem;
}
Expand Down Expand Up @@ -220,10 +231,6 @@
}
}

.menuArrowButton {
display: none;
}

.highlighted {
animation: highlighted 10s forwards;
border: 0.06rem solid $c-pink-active-feed-cards;
Expand Down
5 changes: 4 additions & 1 deletion src/shared/components/Chat/ChatMessage/ChatMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,10 @@ export default function ChatMessage({
isControlledDropdown={false}
isOpen={isMenuOpen}
styles={{
menuButton: styles.menuArrowButton,
menu: styles.elementDropdownMenu,
menuButton: classNames(styles.menuArrowButton, {
[styles.menuArrowButtonVisible]: isMenuOpen,
}),
}}
feedItemId={feedItemId}
onDelete={onMessageDelete}
Expand Down
2 changes: 1 addition & 1 deletion src/shared/components/ElementDropdown/ElementDropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ const ElementDropdown: FC<ElementDropdownProps> = ({
menuButton: classNames(styles?.menuButton, {
"element-dropdown__menu-button--transparent": transparent,
}),
menu: "element-dropdown__menu",
menu: classNames("element-dropdown__menu", styles?.menu),
menuItem: "element-dropdown__menu-item",
}}
/>
Expand Down