Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox unread filter fixes #2317 #2326

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Nov 21, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • added getQueryParam util
  • added changes to the inbox cacheing
    • on cache hydration now we clear inbox items, so we will store inbox items only when unread !== true
    • if cached inbox's unread flag is not equal to the flag of the loading page, then we clear inbox on dehydration of the cache
  • fixed fetching of the chat channels in the cache middle to only fetch channels with messageCount > 0

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 655a8e4
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/655c895c1bdb4b00082679db
😎 Deploy Preview https://deploy-preview-2326--preview-common.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk linked an issue Nov 21, 2023 that may be closed by this pull request
2 tasks
@andreymikhadyuk andreymikhadyuk merged commit 82ebb55 into dev Nov 21, 2023
5 checks passed
@andreymikhadyuk andreymikhadyuk deleted the bugfix/CW-2317-unread-inbox-cache branch November 21, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inbox unread filter fixes
2 participants