Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Darkmode (with colors modulation) #2267 #2339

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Add Darkmode (with colors modulation) #2267 #2339

merged 4 commits into from
Nov 27, 2023

Conversation

roienatan
Copy link
Collaborator

@roienatan roienatan commented Nov 24, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

@netlify Netlify
Copy link

netlify bot commented Nov 24, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 771e42a
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/6563e7e380d86d00085c5ac9
😎 Deploy Preview https://deploy-preview-2339--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roienatan roienatan linked an issue Nov 24, 2023 that may be closed by this pull request
Add Darkmode (with colors modulation) #2267
Closed
8 tasks
@elatif2020
Copy link
Collaborator

elatif2020 commented Nov 26, 2023 •
edited by roienatan
Loading

@roienatan

  1. Need to disable dark mode in the landing page:
  • languages dropdown
  • video\image background sometimes appearing during loading (also mobile)
  • Join waitlist popup should use the light theme
  1. In login with phone, Send code button is invisible if it's disabled. Should be gentle dark gray.
    image
  2. Hover color in the Cancel button - in the Report message pop up - should be dark
    image

@pvm-code pvm-code merged commit 5a0d784 into dev Nov 27, 2023
5 checks passed
@pvm-code pvm-code deleted the cw-2267-dark-mode-fixes branch November 27, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvm-code pvm-code pvm-code approved these changes

@andreymikhadyuk andreymikhadyuk Awaiting requested review from andreymikhadyuk

@budnik9 budnik9 Awaiting requested review from budnik9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Darkmode (with colors modulation)
3 participants
@roienatan @elatif2020 @pvm-code