Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode updated #2 #2353

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Dark mode updated #2 #2353

merged 6 commits into from
Nov 30, 2023

Conversation

roienatan
Copy link
Collaborator

@roienatan roienatan commented Nov 28, 2023 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 371168b
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/656886ac94a4270007716910
😎 Deploy Preview https://deploy-preview-2353--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roienatan roienatan marked this pull request as draft November 28, 2023 01:41
@elatif2020
Copy link
Collaborator

@roienatan
See the dark filter appearing on top of the video after refresh (6sec from the beginning) and also the dark line above the video
Both should be removed
https://github.com/daostack/common-web/assets/72435714/b4440892-fb29-4e31-8ca1-a4b04433ab90

@roienatan roienatan marked this pull request as ready for review November 28, 2023 15:41
@roienatan roienatan requested a review from budnik9 November 30, 2023 00:00
@andreymikhadyuk
Copy link
Collaborator

@roienatan Fix conflicts please.

@pvm-code pvm-code merged commit fc759ed into dev Nov 30, 2023
5 checks passed
@pvm-code pvm-code deleted the cw-2331-dark-mode-updates-round-2 branch November 30, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnik9 budnik9 budnik9 approved these changes

@andreymikhadyuk andreymikhadyuk andreymikhadyuk approved these changes

@pvm-code pvm-code Awaiting requested review from pvm-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roienatan @elatif2020 @andreymikhadyuk @budnik9 @pvm-code