Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD- DM- sender name doesnt shown in channel and bread cramp #2348 #2374

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Nov 30, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • left only userStates in the cache store caching and added removal of either loading, or non-fetched items during saving to cache
  • added changes to cached user fetch to load it on error

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit f1940a1
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/6568839d7cead2000952af2b
😎 Deploy Preview https://deploy-preview-2374--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk linked an issue Nov 30, 2023 that may be closed by this pull request
@andreymikhadyuk andreymikhadyuk marked this pull request as ready for review November 30, 2023 11:59
@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 @NoamQA For now I did PR to dev. I think this should solve the issue which Noam has (at least after a few reloading of the page). Let me know if you think it is better to merge this to prod directly.

@andreymikhadyuk andreymikhadyuk linked an issue Nov 30, 2023 that may be closed by this pull request
@andreymikhadyuk andreymikhadyuk merged commit 12eb025 into dev Nov 30, 2023
5 checks passed
@andreymikhadyuk andreymikhadyuk deleted the bugfix/CW-2348-user-state-chaching branch November 30, 2023 12:55
@NoamQA
Copy link
Collaborator

NoamQA commented Nov 30, 2023

@andreymikhadyuk @elatif2020
it looks ok in dev but there the issue didnt happened
i will be able to know if it was fixed when deployed to prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PROD- DM- sender name doesnt shown in channel and bread cramp Staging bug expanding cards
3 participants