Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on items in mobile navigation bar (Inbox, Spaces and Profile) sometimes not being clicked #2350 #2375

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Clicking on items in mobile navigation bar (Inbox, Spaces and Profile) sometimes not being clicked #2350 #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef7fa74
custom-tab: added user-select: none to prevent selecting text possibl…
roienatan Nov 30, 2023
b406fee
added also -webkit-user-select
roienatan Nov 30, 2023
0ed1c5a
try onContextMenu and useLongPress
roienatan Nov 30, 2023
510f515
Merge branch 'dev' into cw-2350-tabs-layout-click-issue
roienatan Nov 30, 2023
3f5669d
Merge branch 'dev' into cw-2350-tabs-layout-click-issue
roienatan Dec 4, 2023
cdff22f
show hover only when (pointer: fine)
roienatan Dec 4, 2023
823e965
.
roienatan Dec 4, 2023
1e0b34a
.
roienatan Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,15 +204,6 @@ body {
}
}

/* Disable hover effects globally when using a touch device */
@media (hover: none) {
* {
:hover {
opacity: unset !important;
}
}
}

code {
font-family: source-code-pro, Menlo, Monaco, Consolas, "Courier New",
monospace;
Expand Down
24 changes: 18 additions & 6 deletions src/shared/components/Tabs/Tab/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,14 @@
border-bottom: 0.25rem solid var(--tab-bb-color);
cursor: pointer;
transition: color 0.2s, border-bottom-color 0.2s;
user-select: none;
-webkit-user-select: none;

&:active {
--tab-bb-color: var(--tab-inactive-hover-color);
--tab-color: var(--tab-inactive-hover-color);
}

&:hover {
--tab-color: var(--tab-inactive-hover-color);
}

&:first-child {
--tab-ml: 0;
}
Expand All @@ -48,8 +46,7 @@
--tab-bb-color: var(--secondary-text);
--tab-color: var(--secondary-text);

&:active,
&:hover {
&:active {
--tab-bb-color: var(--secondary-text);
--tab-color: var(--secondary-text);
}
Expand All @@ -62,3 +59,18 @@
align-items: center;
border: 0;
}

@media (hover: hover) and (pointer: fine) {
.custom-tab {
&:hover {
--tab-color: var(--tab-inactive-hover-color);
}
}

.custom-tab--active {
&:hover {
--tab-bb-color: var(--secondary-text);
--tab-color: var(--secondary-text);
}
}
}
Loading