Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbox unread filter fixes - Real-time items update #2317 #2381

Merged
merged 8 commits into from
Dec 5, 2023

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Dec 5, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • added logic for fetching of new unread inbox items. The logic is based on the user's inbox counter. We fetch all new items using inbox endpoint with unread flag and stop fetching when last lastDocTimestamp is older than current firstDocTimestamp

Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit c137236
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/656f1ef5a4a9bf000976ee9b
😎 Deploy Preview https://deploy-preview-2381--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk linked an issue Dec 5, 2023 that may be closed by this pull request
2 tasks
@andreymikhadyuk andreymikhadyuk changed the title Inbox unread filter fixes #2317 Inbox unread filter fixes - Real-time items update #2317 Dec 5, 2023
@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 If it works fine for we can merge it, but after Daniel's change to inbox collection I will change the logic anyway.

@elatif2020
Copy link
Collaborator

@elatif2020 If it works fine for we can merge it, but after Daniel's change to inbox collection I will change the logic anyway.

@andreymikhadyuk
Okay as you prefer

@andreymikhadyuk andreymikhadyuk merged commit ec3d840 into dev Dec 5, 2023
5 of 6 checks passed
@andreymikhadyuk andreymikhadyuk deleted the feature/CW-2317-unread-enhancements branch December 5, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inbox unread filter fixes
3 participants