-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: after deleting a message it disappears only after refresh #2354 #2398
Conversation
✅ Deploy Preview for preview-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@MeyerPV Untitled.video.-.Made.with.Clipchamp.4.mp4 |
@MeyerPV If PR is approved by Latif, then merge please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeyerPV can you please fix the location of the loader in this PR?
See ticket also
Or actually to be consistent with deleting a discussion/proposal instead of a loader we should show "deleting...". What do you think? @elatif2020 |
Thanks @roienatan this is a good point. For now both are good. I hope we will make soon a broader work to use the same standard behaviors across the app (especially same pop-ups design). |
#2354
What was changed?