Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: after deleting a message it disappears only after refresh #2354 #2398

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

pvm-code
Copy link
Collaborator

#2354

What was changed?

  • Added handler action for deleting messages.

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit 0665b34
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/658435aad7cf6f0008202ee7
😎 Deploy Preview https://deploy-preview-2398--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pvm-code pvm-code linked an issue Dec 15, 2023 that may be closed by this pull request
2 tasks
@elatif2020
Copy link
Collaborator

elatif2020 commented Dec 17, 2023

@MeyerPV
See the screen recording:
After message deletion the focus is been changed to another item in the inbox.
Also the loader location in the delete message button should be centered.

Untitled.video.-.Made.with.Clipchamp.4.mp4

@andreymikhadyuk
Copy link
Collaborator

@MeyerPV If PR is approved by Latif, then merge please.

Copy link
Collaborator

@roienatan roienatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeyerPV can you please fix the location of the loader in this PR?
image

See ticket also

@roienatan
Copy link
Collaborator

Or actually to be consistent with deleting a discussion/proposal instead of a loader we should show "deleting...". What do you think? @elatif2020

@elatif2020
Copy link
Collaborator

Or actually to be consistent with deleting a discussion/proposal instead of a loader we should show "deleting...". What do you think? @elatif2020

Thanks @roienatan this is a good point. For now both are good. I hope we will make soon a broader work to use the same standard behaviors across the app (especially same pop-ups design).
So if it's easy let's switch to "deleting..." like we have for deletion of discussions, and otherwise we can stay with the spinner, just move it to the center.

@pvm-code pvm-code merged commit cfb7ab4 into dev Dec 21, 2023
5 checks passed
@pvm-code pvm-code deleted the CW-2354-message-deletion branch December 21, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat: after deleting a message it disappears only after refresh
5 participants