Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firebase version #2286 #2406

Merged
merged 9 commits into from
Dec 19, 2023
Merged

Conversation

andreymikhadyuk
Copy link
Collaborator

@andreymikhadyuk andreymikhadyuk commented Dec 18, 2023

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • removed @react-firebase/auth and react-firebase-hooks dependencies, because I do see their usages
  • updated firebase version to the latest
  • fixed things related to the version change

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit f30994f
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/65813e1e353427000825a1dc
😎 Deploy Preview https://deploy-preview-2406--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andreymikhadyuk andreymikhadyuk linked an issue Dec 18, 2023 that may be closed by this pull request
@elatif2020
Copy link
Collaborator

@andreymikhadyuk
on desktop it is working well so far
on mobile (Firefox) I have an issue logging in :
https://github.com/daostack/common-web/assets/72435714/7251987f-2828-4cde-ba16-0bd8db5bcad7

Screenshot_20231218_140916_Firefox.jpg

@andreymikhadyuk
Copy link
Collaborator Author

@elatif2020 Check it out please again, now should work fine.

@andreymikhadyuk andreymikhadyuk merged commit 272d3dc into dev Dec 19, 2023
5 checks passed
@andreymikhadyuk andreymikhadyuk deleted the bugfix/CW-2286-firebase-version branch December 19, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading... issue on DEV with uncaught error in console
3 participants