Deleted messages re-show up in chat #2417 #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preview-common ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@budnik9 notice the deploy preview failed here |
pvm-code
requested changes
Dec 28, 2023
| const added: DiscussionMessage[] = []; | ||
| const removed: DiscussionMessage[] = []; | ||
|
|
||
| snapshot.docChanges().forEach((docChange) => { |
There was a problem hiding this comment.
Maybe instead of this, we somehow can filter deleted messages inside query?
There was a problem hiding this comment.
We don't need filter them out, we need them to remove from the cache
pvm-code
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developmentsection of this PR.What was changed?