Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips doesn't appear #2481 #2483

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Tooltips doesn't appear #2481 #2483

merged 1 commit into from
Jan 9, 2024

Conversation

budnik9
Copy link
Contributor

@budnik9 budnik9 commented Jan 8, 2024 •
edited
Loading

  • PR title equals to the ticket name
  • I added the ticket to the Development section of this PR.

What was changed?

  • Got rid of the default value for the shouldOpenOnHover property of a tooltip

@budnik9 budnik9 self-assigned this Jan 8, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2024 •
edited
Loading

✅ Deploy Preview for preview-common ready!

Name Link
🔨 Latest commit f8a3b28
🔍 Latest deploy log https://app.netlify.com/sites/preview-common/deploys/659d3fa4a5b4a60008f5f229
😎 Deploy Preview https://deploy-preview-2483--preview-common.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@budnik9 budnik9 linked an issue Jan 8, 2024 that may be closed by this pull request
Tooltips doesn't appear #2481
Closed
roienatan
roienatan reviewed Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@roienatan roienatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@budnik9 please see why the tests are falling.

@andreymikhadyuk andreymikhadyuk force-pushed the bugfix/CW-2481-tooltip-isse branch from 283dc69 to f8a3b28 Compare January 9, 2024 12:44
@andreymikhadyuk andreymikhadyuk changed the base branch from dev to staging January 9, 2024 12:44
@andreymikhadyuk andreymikhadyuk force-pushed the bugfix/CW-2481-tooltip-isse branch from 50f0333 to f8a3b28 Compare January 9, 2024 13:02
@andreymikhadyuk andreymikhadyuk merged commit 5b01e40 into staging Jan 9, 2024
5 of 6 checks passed
@andreymikhadyuk andreymikhadyuk deleted the bugfix/CW-2481-tooltip-isse branch January 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roienatan roienatan roienatan left review comments

@andreymikhadyuk andreymikhadyuk andreymikhadyuk approved these changes

@MeyerPV MeyerPV Awaiting requested review from MeyerPV

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltips doesn't appear
3 participants
@budnik9 @andreymikhadyuk @roienatan