Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iterateObs() not being called with enough parameters. #2

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

potterzot
Copy link

Hi Darin - I was super happy to come across your Conley SE implementation, thanks! When I was incorporating it into a package I had to make some changes to get it to run. It seems like maybe the iterateObs() function wasn't being called with the dt, Xvars, balanced_pnl, and verbose parameters from ConleySEs().

The only substantive difference in the PR is the calls to iterateObs() from ConleySEs(). The others are superfluous and probably a result of me just coping the entire function over from my package files.

PS - Your work on conflict and commodity prices is interesting. I was looking at conflict and resource scarcity a la this paper but haven't had a chance to revisit it recently:

Almer, Christian, Jérémy Laurent-Lucchetti, and Manuel Oechslin. 2017. “Water Scarcity and Rioting:
Disaggregated Evidence from Sub-Saharan Africa.” Journal of Environmental Economics and Management 86. Elsevier BV:193–209. https://doi.org/10.1016/j.jeem.2017.06.002.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant