Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed robolectric and electricspock dependency #770

Merged
merged 28 commits into from
May 21, 2022
Merged

Removed robolectric and electricspock dependency #770

merged 28 commits into from
May 21, 2022

Conversation

nrbrook
Copy link
Contributor

@nrbrook nrbrook commented Nov 13, 2021

Resolves #769

This PR replaces Robolectric with handcrafted stubs. It also updates groovy and spock. All tests pass.

@nrbrook
Copy link
Contributor Author

nrbrook commented Nov 13, 2021

Agh, missed the test in the sample. Will fix later.

@nrbrook
Copy link
Contributor Author

nrbrook commented Nov 13, 2021

This PR is now complete

@dariuszseweryn
Copy link
Owner

This looks amazing! 🚀 In the long run I want to put most of Android specific APIs behind a library-only accessor that would be dead simple and test only the library logic.
Anyway — I will test it and merge in the near future

@nrbrook
Copy link
Contributor Author

nrbrook commented Nov 15, 2021

Sounds good. This may help in that process. Some of the classes have only the methods used stubbed. But for now, this enables the transition to gradle 7 and allows us to upgrade groovy, junit and spock.

@dariuszseweryn
Copy link
Owner

dariuszseweryn commented Dec 4, 2021 •
edited
Loading

I finally got a moment to test properly. I have difficulties in running :mockrxandroidble:androidJavadocs with Java 11. There seem to be a problem with the task seeing dependencies of mockrxandroidble like the rxandroidble or annotation/rxjava libraries
I am not a pro when it comes to gradle setup and searching the Internet didn't got me further. Any ideas?

@dariuszseweryn dariuszseweryn mentioned this pull request Dec 15, 2021
Closed
@nrbrook
Copy link
Contributor Author

nrbrook commented Mar 3, 2022

@dariuszseweryn this should work now with my latest commit. Not sure if this is the ideal way to achieve it but it works!

@nrbrook
Copy link
Contributor Author

nrbrook commented Mar 23, 2022

@dariuszseweryn This branch now contains #763 and passes

@nrbrook
Copy link
Contributor Author

nrbrook commented Mar 26, 2022

I decided to fork this project so we can maintain it more actively and merge the PRs we had open. I've forked at https://github.com/NRB-Tech/RxAndroidBle/ and it's on Maven Central as io.nrbtech.rxandroidble. I've merged this PR there.

@dariuszseweryn
Copy link
Owner

dariuszseweryn commented May 21, 2022 •
edited
Loading

Hi @nrbrook
Sorry for such long silence. Had some time off and I didn't get notifications on my email so I missed a whole lot of events happening here. Thank you for your contributions these will help a great deal
Since I have missed the notifications I ended up redoing some of work you did

@dariuszseweryn dariuszseweryn merged commit d203b41 into dariuszseweryn:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Robolectric and electricspock dependencies
2 participants
@nrbrook @dariuszseweryn