Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2551 add datetoday to the standard library #2577

Conversation

thomasmarcel
Copy link

Add Date::today, solving #2551 .

@pbiggar
Copy link
Member

pbiggar commented Jun 10, 2020

Wonderful, thanks!

@thomasmarcel
Copy link
Author

My pleasure!

@pbiggar
Copy link
Member

pbiggar commented Jun 10, 2020

Would you mind rebasing? CI was broken when you made the change (we were deleting old builds so we could make the repo public).

I tried to rebase for you but couldn't push to the PR branch, sorry about the hassle!

@thomasmarcel
Copy link
Author

Not at all! I thought you could squash commits together, but from now on I'll deliver stuff rebased.

One min.

@thomasmarcel thomasmarcel force-pushed the feature/2551-add-datetoday-to-the-standard-library branch from 9e14fb7 to 079b8ce Compare June 10, 2020 18:33
@pbiggar pbiggar merged commit 721279a into darklang:master Jun 10, 2020
@pbiggar
Copy link
Member

pbiggar commented Jun 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants