Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the mask hash calculation #17872

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Simplify the mask hash calculation #17872

merged 1 commit into from
Nov 21, 2024

Conversation

jenshannoschwalm
Copy link
Collaborator

  1. Use dt_hash() directly instead of calculation after copying avoiding malloc/free
  2. Use dt_mask_id_t instead of int

@jenshannoschwalm
Simplify the mask hash calculation
5d4e9e6 
1. Use dt_hash() directly instead of calculation after copying avoiding malloc/free
2. Use dt_mask_id_t instead of int
@jenshannoschwalm jenshannoschwalm added the scope: codebase making darktable source code easier to manage label Nov 21, 2024
@jenshannoschwalm jenshannoschwalm added this to the 5.0 milestone Nov 21, 2024
TurboGit
TurboGit approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@TurboGit TurboGit merged commit fa7b89a into darktable-org:master Nov 21, 2024
6 checks passed
@jenshannoschwalm jenshannoschwalm deleted the mask_hash branch November 21, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees
No one assigned
Labels
scope: codebase making darktable source code easier to manage
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshannoschwalm @TurboGit